refactor(linter): refactor LintBuilder to prep for nested configs#8034
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 5, 2025
Conversation
This was referenced Dec 19, 2024
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
camc314
force-pushed
the
c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_
branch
from
73d39ed to
f6523f6
Compare
camc314
force-pushed
the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
from
ae07fda to
42adf86
Compare
Member
|
Thanks for taking a look at this, I'll review this as soon as possible. I had a draft of the nested config work on my laptop but wasn't happy with it so far. |
Contributor
Author
ah sorry! i didn't realize you had already started implementing this. |
camc314
force-pushed
the
c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_
branch
from
f6523f6 to
0487198
Compare
camc314
force-pushed
the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
3 times, most recently
from
30c712c to
0eeb0e0
Compare
Member
|
You may merge after fixing the compile error. |
Boshen
changed the base branch from
c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_
to
graphite-base/8034
Boshen
force-pushed
the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
from
0eeb0e0 to
e46b6e7
Compare
Boshen
force-pushed
the
graphite-base/8034
branch
from
0487198 to
952d7e4
Compare
Boshen
force-pushed
the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
from
e46b6e7 to
263abe6
Compare
camchenry
force-pushed
the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
from
263abe6 to
5c25148
Compare
CodSpeed Performance ReportMerging #8034 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
from
5c25148 to
ad6ab1d
Compare
Member
|
@camc314 I pushed some changes to fix errors where we were using |
Member
Merge activity
|
…8034) More simplification/preparations for nested configurations: 1. renames `LinterBuilder` to `ConfigStoreBuilder` 2. moves the `options` logic out of `LintBuilder` 3. make `ConfigStoreBuilder::build()` return a result (currently always returns OK, but it will return errors when nested config is implemented The next steps to implement nested config which i hope to do in the next week are: 1. refactor the `from_oxlintrc` to accept a file path 2. introduce a new method on `ConfigStoreBuilder` (name TBC) that walks all child directories, collecting `.oxlintrc` files. these will be put into `ConfigStore` as a hash map of path > config.
Boshen
force-pushed
the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
from
ad6ab1d to
3c534ae
Compare
graphite-app
bot
deleted the
c/12-19-refactor_linter_refactor_lintbuilder_to_prep_for_nested_configs
branch
Boshen
added a commit
that referenced
this pull request
Jan 13, 2025
## [0.15.6] - 2025-01-13 ### Features - 457aa31 linter: Implement `no-lone-blocks` rule (#8145) (Yuichiro Yamashita) ### Refactor - aea9551 ast: Simplify `get_identifier_reference` of `TSType` and `TSTypeName` (#8273) (Dunqing) - 43ed3e1 linter: Add output formatter (#8436) (Alexander S.) - 4e05e66 linter: Remove glob for windows (#8390) (Alexander S.) - b19d809 linter: Split `unicorn/prefer-spread` and `eslint/prefer-spread` into own rules (#8329) (Alexander S.) - 3c534ae linter: Refactor `LintBuilder` to prep for nested configs (#8034) (camc314) - 2f9fab9 linter: Remove remapping for plugin name in diagnostics (#8223) (Alexander S.) ### Testing - b6c1546 linter: Use plugin name instead of category for finding rule (#8353) (Alexander S.) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More simplification/preparations for nested configurations:
LinterBuildertoConfigStoreBuilderoptionslogic out ofLintBuilderConfigStoreBuilder::build()return a result (currently always returns OK, but it will return errors when nested config is implementedThe next steps to implement nested config which i hope to do in the next week are:
from_oxlintrcto accept a file pathConfigStoreBuilder(name TBC) that walks all child directories, collecting.oxlintrcfiles. these will be put intoConfigStoreas a hash map of path > config.