Skip to content

Comments

refactor(transformer/class-properties): make transform_instance_assignment_expression more generic#7956

Closed
Dunqing wants to merge 2 commits intomainfrom
12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic
Closed

refactor(transformer/class-properties): make transform_instance_assignment_expression more generic#7956
Dunqing wants to merge 2 commits intomainfrom
12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 17, 2024

This function can also transform super assignment expressions, but it needs to use different helper functions and has different parameters. Transform this function to accept getter(_classPrivateFieldGet2) and setter(_classPrivateFieldSet2) functions.

Copy link
Member Author

Dunqing commented Dec 17, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title refactor(transformer/class-properties): make transform_instance_assignment_expression more generic refactor(transformer/class-properties): make transform_instance_assignment_expression more generic Dec 17, 2024
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 17, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #7956 will not alter performance

Comparing 12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic (8a4be03) with main (1314c97)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen changed the base branch from 12-17-docs_transformer_class-properties_remove_oudated_todo_for_assignment_expression to graphite-base/7956 December 17, 2024 04:41
@Boshen Boshen force-pushed the 12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic branch from 3617e34 to 18eba77 Compare December 17, 2024 04:45
@Boshen Boshen force-pushed the graphite-base/7956 branch from e02c28e to 18441af Compare December 17, 2024 04:45
@Boshen Boshen changed the base branch from graphite-base/7956 to main December 17, 2024 04:46
@Boshen Boshen force-pushed the 12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic branch from 18eba77 to a00c9b4 Compare December 17, 2024 04:46
@Dunqing Dunqing force-pushed the 12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic branch from a00c9b4 to 79767e8 Compare December 17, 2024 09:16
@Dunqing Dunqing force-pushed the 12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic branch from 79767e8 to 8a4be03 Compare December 17, 2024 09:19
@overlookmotel overlookmotel marked this pull request as ready for review December 17, 2024 09:43
@overlookmotel overlookmotel self-requested a review as a code owner December 17, 2024 09:43
@Dunqing Dunqing marked this pull request as draft December 18, 2024 02:31
overlookmotel pushed a commit that referenced this pull request Dec 18, 2024
…sions within static prop initializer (#7991)

Alternative of #7956 and #7959. Unlike the previous method, adapting duplicating the same logic rather than making the same logic transform function to be generic
@Dunqing Dunqing closed this Dec 18, 2024
@Boshen Boshen deleted the 12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic branch January 14, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant