refactor(linter): use Expression::is_super#7850
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 13, 2024
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #7850 will not alter performanceComparing Summary
|
Member
Merge activity
|
Dunqing
approved these changes
Dec 13, 2024
Dunqing
pushed a commit
that referenced
this pull request
Dec 13, 2024
Simplify code by using `Expression::is_super` which was introduced in #7831. Also remove a lifetime bound which is unnecessary and replace use of `bool::then` (which I always find hard to read) with more explicit code.
Dunqing
force-pushed
the
12-13-refactor_linter_use_expression_is_super_
branch
from
179ea18 to
8f3444f
Compare
Simplify code by using `Expression::is_super` which was introduced in #7831. Also remove a lifetime bound which is unnecessary and replace use of `bool::then` (which I always find hard to read) with more explicit code.
Dunqing
force-pushed
the
12-13-refactor_linter_use_expression_is_super_
branch
from
8f3444f to
e55ab24
Compare
graphite-app
bot
deleted the
12-13-refactor_linter_use_expression_is_super_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify code by using
Expression::is_superwhich was introduced in #7831.Also remove a lifetime bound which is unnecessary and replace use of
bool::then(which I always find hard to read) with more explicit code.