feat(ast): implement From<Argument> for ArrayExpressionElement#7830
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 13, 2024
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #7830 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
12-13-feat_ast_implement_from_argument_for_arrayexpressionelement
branch
3 times, most recently
from
e66c18d to
84114bd
Compare
overlookmotel
approved these changes
Dec 13, 2024
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
I'll make a change to this in a follow-up.
Member
Merge activity
|
overlookmotel
pushed a commit
that referenced
this pull request
Dec 13, 2024
overlookmotel
force-pushed
the
12-13-feat_ast_implement_from_argument_for_arrayexpressionelement
branch
from
84114bd to
e633cf0
Compare
overlookmotel
pushed a commit
that referenced
this pull request
Dec 13, 2024
overlookmotel
force-pushed
the
12-13-feat_ast_implement_from_argument_for_arrayexpressionelement
branch
from
e633cf0 to
38c849b
Compare
Boshen
force-pushed
the
12-13-feat_ast_implement_from_argument_for_arrayexpressionelement
branch
from
38c849b to
6466a4a
Compare
graphite-app
bot
deleted the
12-13-feat_ast_implement_from_argument_for_arrayexpressionelement
branch
Dunqing
pushed a commit
that referenced
this pull request
Dec 13, 2024
…nElement` conversion (#7848) Follow-on after #7830. Refactor. Use an exhaustive match in implementation of `From<Argument<'a>> for ArrayExpressionElement<'a>`. At present this change makes no difference. But the reason I feel an exhaustive match is preferable here is that if we add a variant to `Argument` enum later, then this match will be missing an arm to handle that variant, and compiler will refuse to compile until we deal with it. Whereas before this PR, compiler would not complain, but instead it'd be a runtime panic when `into_expression` discovers that the new `Argument` variant is not an `Expression`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.