Skip to content

chore(transformer): support passing babel options path in example#7790

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-11-chore_transformer_support_passing_babel_options_path_in_example
Dec 11, 2024
Merged

chore(transformer): support passing babel options path in example#7790
graphite-app[bot] merged 1 commit intomainfrom
12-11-chore_transformer_support_passing_babel_options_path_in_example

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented Dec 11, 2024

Sometimes we want to use Babel test's options to test some code, If the example can get the TransformerOptions from Babel options, then we can easily do it

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 11, 2024
Copy link
Copy Markdown
Member Author

Dunqing commented Dec 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing
Copy link
Copy Markdown
Member Author

Dunqing commented Dec 11, 2024

Merging without review as it's just an example changed

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 11, 2024
Copy link
Copy Markdown
Member Author

Dunqing commented Dec 11, 2024

Merge activity

  • Dec 10, 7:32 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 10, 7:32 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 7:37 PM EST: A user merged this pull request with the Graphite merge queue.

)

Sometimes we want to use Babel test's options to test some code, If the example can get the TransformerOptions from Babel options, then we can easily do it
@Dunqing Dunqing force-pushed the 12-11-chore_transformer_support_passing_babel_options_path_in_example branch from 27e648b to 4a524ed Compare December 11, 2024 00:33
@graphite-app graphite-app bot merged commit 4a524ed into main Dec 11, 2024
@graphite-app graphite-app bot deleted the 12-11-chore_transformer_support_passing_babel_options_path_in_example branch December 11, 2024 00:37
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #7790 will not alter performance

Comparing 12-11-chore_transformer_support_passing_babel_options_path_in_example (4a524ed) with main (caa57f1)

Summary

✅ 29 untouched benchmarks

@overlookmotel
Copy link
Copy Markdown
Member

This will be really helpful. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants