test(semantic): re-organize snapshot-based tests#7494
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 27, 2024
Merged
Conversation
github-actions
bot
added
A-semantic
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 26, 2024
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Boshen
changed the base branch from
10-09-fix_semantic_correctly_resolve_binding_for_return_type_of_functions
to
graphite-base/7494
Boshen
force-pushed
the
11-26-test_semantic_re-organize_snapshot-based_tests
branch
from
120a2fc to
b4786d9
Compare
Boshen
force-pushed
the
graphite-base/7494
branch
from
dd514ba to
f3850eb
Compare
Boshen
force-pushed
the
11-26-test_semantic_re-organize_snapshot-based_tests
branch
from
b4786d9 to
7580e45
Compare
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
I don't know how the semantic fixtures work, so can't review. But it looks reasonable. @Dunqing if you're happy with it, please merge.
Contributor
Merge activity
|
Reorignize tests by splitting tests to js, ts, and jsx folders
Dunqing
force-pushed
the
11-26-test_semantic_re-organize_snapshot-based_tests
branch
from
7580e45 to
4b0720a
Compare
graphite-app
bot
deleted the
11-26-test_semantic_re-organize_snapshot-based_tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorignize tests by splitting tests to js, ts, and jsx folders