refactor(ast): remove inherit_variants! from TSEnumMemberName#7248
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 12, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #7248 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
) #7219 removed all variants of `TSEnumMemberName` except `IdentifierName` and `StringLiteral`. It no longer inherits variants from `Expression`, so we can remove the `inherit_variants!` macro wrapper. The discriminants no longer need to avoid clashes with `Expression`'s, so they can start at 0.
Boshen
force-pushed
the
11-12-refactor_ast_remove_inherit_variants_from_tsenummembername_
branch
from
2893145 to
d3d58f8
Compare
graphite-app
bot
deleted the
11-12-refactor_ast_remove_inherit_variants_from_tsenummembername_
branch
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
) #7219 removed all variants of `TSEnumMemberName` except `IdentifierName` and `StringLiteral`. It no longer inherits variants from `Expression`, so we can remove the `inherit_variants!` macro wrapper. The discriminants no longer need to avoid clashes with `Expression`'s, so they can start at 0.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
) #7219 removed all variants of `TSEnumMemberName` except `IdentifierName` and `StringLiteral`. It no longer inherits variants from `Expression`, so we can remove the `inherit_variants!` macro wrapper. The discriminants no longer need to avoid clashes with `Expression`'s, so they can start at 0.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
) #7219 removed all variants of `TSEnumMemberName` except `IdentifierName` and `StringLiteral`. It no longer inherits variants from `Expression`, so we can remove the `inherit_variants!` macro wrapper. The discriminants no longer need to avoid clashes with `Expression`'s, so they can start at 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7219 removed all variants of
TSEnumMemberNameexceptIdentifierNameandStringLiteral. It no longer inherits variants fromExpression, so we can remove theinherit_variants!macro wrapper.The discriminants no longer need to avoid clashes with
Expression's, so they can start at 0.