Skip to content

Comments

feat(minifier): minify alternated one child if block#7231

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-10-feat_minifier_minify_alternated_one_child_if_block
Nov 26, 2024
Merged

feat(minifier): minify alternated one child if block#7231
graphite-app[bot] merged 1 commit intomainfrom
11-10-feat_minifier_minify_alternated_one_child_if_block

Conversation

@7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 10, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Nov 10, 2024
@7086cmd Graphite App
Copy link
Contributor Author

7086cmd commented Nov 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@7086cmd 7086cmd mentioned this pull request Nov 10, 2024
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7231 will create unknown performance changes

Comparing 11-10-feat_minifier_minify_alternated_one_child_if_block (97af341) with main (2ac9f96)

Summary

🆕 30 new benchmarks

Benchmarks breakdown

Benchmark main 11-10-feat_minifier_minify_alternated_one_child_if_block Change
🆕 codegen[checker.ts] N/A 24.7 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 77.5 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 404.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24.3 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.3 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.1 s N/A
🆕 linter[checker.ts] N/A 2.6 s N/A
🆕 minifier[antd.js] N/A 150.9 ms N/A
🆕 minifier[react.development.js] N/A 1.4 ms N/A
🆕 minifier[typescript.js] N/A 241.7 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 78.1 µs N/A
🆕 parser[antd.js] N/A 106.7 ms N/A
🆕 parser[cal.com.tsx] N/A 24.7 ms N/A
🆕 parser[checker.ts] N/A 53.6 ms N/A
🆕 parser[pdf.mjs] N/A 17.4 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 97.5 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@7086cmd Graphite App
Copy link
Contributor Author

7086cmd commented Nov 10, 2024

So we can assume it's a problem due to enabling a new peephole, same as #6698, #6266.

@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch 2 times, most recently from e9862e1 to 4ea0205 Compare November 11, 2024 08:41
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_alternated_one_child_if_block branch from 81612ea to e2f5288 Compare November 11, 2024 08:41
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch 2 times, most recently from 0ff1977 to a1495e7 Compare November 26, 2024 14:36
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_alternated_one_child_if_block branch from e2f5288 to 9986c5c Compare November 26, 2024 14:38
Base automatically changed from 11-10-feat_minifier_minify_one_child_if_statement_expression to main November 26, 2024 14:48
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_alternated_one_child_if_block branch from 9986c5c to f646b25 Compare November 26, 2024 14:49
@Boshen Boshen marked this pull request as ready for review November 26, 2024 14:51
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2024
@Boshen Graphite App
Copy link
Member

Boshen commented Nov 26, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 26, 9:51 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 9:56 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 26, 10:07 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_alternated_one_child_if_block branch from f646b25 to 97af341 Compare November 26, 2024 15:00
@graphite-app graphite-app bot merged commit 97af341 into main Nov 26, 2024
@graphite-app graphite-app bot deleted the 11-10-feat_minifier_minify_alternated_one_child_if_block branch November 26, 2024 15:07
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@7086cmd @Boshen