fix(minifier): prevent removing if when side effected#7223
Closed
7086cmd wants to merge 1 commit into11-09-test_minifier_fix_minimize_condition_testsfrom
Closed
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7086cmd
force-pushed
the
11-09-fix_minifier_prevent_removing_if_when_side_effected
branch
2 times, most recently
from
db10bd9 to
52026c4
Compare
CodSpeed Performance ReportMerging #7223 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
11-09-test_minifier_fix_minimize_condition_tests
branch
2 times, most recently
from
4ba479a to
c0e4c59
Compare
Boshen
force-pushed
the
11-09-fix_minifier_prevent_removing_if_when_side_effected
branch
from
52026c4 to
85e106b
Compare
7086cmd
force-pushed
the
11-09-test_minifier_fix_minimize_condition_tests
branch
from
c0e4c59 to
1bbfa1b
Compare
7086cmd
force-pushed
the
11-09-fix_minifier_prevent_removing_if_when_side_effected
branch
from
85e106b to
82c2fec
Compare
7086cmd
force-pushed
the
11-09-test_minifier_fix_minimize_condition_tests
branch
from
0dd1d43 to
e2101f9
Compare
7086cmd
force-pushed
the
11-09-fix_minifier_prevent_removing_if_when_side_effected
branch
from
6e68b3c to
7771afc
Compare
7086cmd
force-pushed
the
11-09-test_minifier_fix_minimize_condition_tests
branch
from
e2101f9 to
e501872
Compare
7086cmd
force-pushed
the
11-09-fix_minifier_prevent_removing_if_when_side_effected
branch
from
7771afc to
6ab27ca
Compare
This was referenced Nov 10, 2024
Boshen
deleted the
11-09-fix_minifier_prevent_removing_if_when_side_effected
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #7209
But it can be optimized but not in this case.