Skip to content

Comments

feat(linter): add import/first rule#7180

Merged
Boshen merged 1 commit intooxc-project:mainfrom
pumano:feat/import-first-rule
Nov 9, 2024
Merged

feat(linter): add import/first rule#7180
Boshen merged 1 commit intooxc-project:mainfrom
pumano:feat/import-first-rule

Conversation

@pumano
Copy link
Contributor

@pumano pumano commented Nov 6, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Nov 6, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #7180 will not alter performance

Comparing pumano:feat/import-first-rule (329948f) with main (5ab1ff6)

Summary

✅ 30 untouched benchmarks

@pumano pumano force-pushed the feat/import-first-rule branch from c7a54ef to aae10fc Compare November 7, 2024 05:47
@pumano pumano requested a review from Boshen November 7, 2024 05:50
@pumano pumano force-pushed the feat/import-first-rule branch from aae10fc to 4b60363 Compare November 7, 2024 08:10
@pumano pumano force-pushed the feat/import-first-rule branch from 4b60363 to 7c049e1 Compare November 7, 2024 15:13
@pumano pumano requested a review from camchenry November 7, 2024 15:13
@pumano pumano force-pushed the feat/import-first-rule branch from 7c049e1 to 329948f Compare November 7, 2024 18:00
@pumano pumano requested a review from camc314 November 7, 2024 18:01
@pumano
Copy link
Contributor Author

pumano commented Nov 8, 2024

@camc314 I apply your suggested changes. Could you please look at it?

@Boshen Boshen merged commit 4d577cf into oxc-project:main Nov 9, 2024
@pumano pumano deleted the feat/import-first-rule branch November 9, 2024 09:29
@oxc-bot oxc-bot mentioned this pull request Nov 9, 2024
Boshen added a commit that referenced this pull request Nov 9, 2024
## [0.11.1] - 2024-11-09

### Features

- 4dd9b60 editor/vscode: Replace existing output channel and trace
output channel with a single LogOutputChannel (#7196) (Nicholas Rayburn)
- 1fcd709 linter: Add jsx support for only-used-in-recursion (#7120)
(no-yan)
- 4d577cf linter: Add `import/first` rule (#7180) (Dmitry Zakharov)
- 9b8973f linter: Add `import/unambiguous` rule (#7187) (Dmitry
Zakharov)
- 5ab1ff6 linter: Implement @typescript-eslint/no-unsafe-function-type
(#6989) (Orenbek)

### Bug Fixes

- eea8879 editor/vscode: Update language client id to fix the resolution
of the oxc.trace.server setting (#7181) (Nicholas Rayburn)
- b73cfd9 linter: Fix `is_method_call` with parentheses and chain
expression (#7095) (tbashiyy)

### Refactor

- 8c0a362 linter: Use `ctx.source_range(comment.content_span())` API
(#7155) (Boshen)
- c5485ae semantic: Add `ancestor_kinds` iterator function (#7217)
(camchenry)
- abf1602 semantic: Rename `iter_parents` to `ancestors` (#7216)
(camchenry)
- 42171eb semantic: Rename `ancestors` to `ancestor_ids` (#7215)
(camchenry)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants