fix(cli): Explicitly turn on tree shaking plugin by default, add option to disable#7057
Closed
mimbrown wants to merge 1 commit intooxc-project:mainfrom
Closed
fix(cli): Explicitly turn on tree shaking plugin by default, add option to disable#7057mimbrown wants to merge 1 commit intooxc-project:mainfrom
mimbrown wants to merge 1 commit intooxc-project:mainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
mimbrown
changed the title
Contributor
|
Are we sure we want this plugin turned on by default at all? |
Member
|
I don't think so, leave this to me. |
Boshen
added a commit
that referenced
this pull request
Nov 20, 2024
Member
|
Thank you for the PR. I decided to remove the plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7031
Explicitly marks the tree shaking plugin as ON by default. Adds
--disable-tree-shaking-pluginoption to disable.