Skip to content

Comments

fix(napi/transform)!: remove unused declaration.sourcemap option#7013

Closed
Boshen wants to merge 2 commits intomainfrom
10-30-fix_napi_transform_remove_unused_declaration.sourcemap_option
Closed

fix(napi/transform)!: remove unused declaration.sourcemap option#7013
Boshen wants to merge 2 commits intomainfrom
10-30-fix_napi_transform_remove_unused_declaration.sourcemap_option

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 30, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Oct 30, 2024

@Boshen Boshen force-pushed the 10-30-fix_napi_transform_fix_typescript.declaration_option_not_working branch from ffe0fc8 to 06064c9 Compare October 30, 2024 03:16
@Boshen Boshen force-pushed the 10-30-fix_napi_transform_remove_unused_declaration.sourcemap_option branch from ff47330 to 6a08ba7 Compare October 30, 2024 03:16
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #7013 will not alter performance

Comparing 10-30-fix_napi_transform_remove_unused_declaration.sourcemap_option (6a08ba7) with main (a6fcd81)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen changed the base branch from 10-30-fix_napi_transform_fix_typescript.declaration_option_not_working to graphite-base/7013 October 30, 2024 03:21
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Merge activity

@Dunqing
Copy link
Member

Dunqing commented Oct 30, 2024

Shouldn't we support this? See #4313

@graphite-app graphite-app bot changed the base branch from graphite-base/7013 to main October 30, 2024 03:29
@Dunqing Dunqing marked this pull request as draft October 30, 2024 03:29
@Boshen
Copy link
Member Author

Boshen commented Oct 30, 2024

Shouldn't we support this? See #4313

This is on the declaration api, not the transform.typescript.declaration api

I'll take a look at the APIs later.

@Dunqing
Copy link
Member

Dunqing commented Oct 30, 2024

Shouldn't we support this? See #4313

This is on the declaration api, not the transform.typescript.declaration api

I'll take a look at the APIs later.

Oh, yes, you are right! Feel free to continue merging

@Boshen Boshen closed this Nov 24, 2024
@Boshen Boshen deleted the 10-30-fix_napi_transform_remove_unused_declaration.sourcemap_option branch November 24, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants