Skip to content

Comments

refactor(ast_tools): remove well_known! macro#6957

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_remove_well_known_macro
Oct 28, 2024
Merged

refactor(ast_tools): remove well_known! macro#6957
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_remove_well_known_macro

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

Remove well_known! macro by expanding code manually.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 15:24
@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior A-ast-tools Area - AST tools labels Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from e7f19b8 to aafdaf6 Compare October 27, 2024 15:31
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from f21fabf to 30d847d Compare October 27, 2024 15:31
Copy link
Member Author

overlookmotel commented Oct 27, 2024

Merge activity

  • Oct 27, 11:31 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 8:02 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 8:06 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6952.
  • Oct 27, 8:06 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6952.
  • Oct 27, 8:22 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 8:23 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 8:57 PM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from aafdaf6 to 269d8ce Compare October 27, 2024 19:02
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from 30d847d to 240a175 Compare October 27, 2024 19:03
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 269d8ce to bf828f1 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from 240a175 to e977b50 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from bf828f1 to 15ea58e Compare October 27, 2024 19:31
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from e977b50 to 7074d3d Compare October 27, 2024 19:32
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 15ea58e to 6e0f6ca Compare October 27, 2024 23:50
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from 7074d3d to c3fa007 Compare October 27, 2024 23:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 6e0f6ca to 7b0aed4 Compare October 28, 2024 00:08
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from c3fa007 to 3916cf0 Compare October 28, 2024 00:08
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 7b0aed4 to b7bf01b Compare October 28, 2024 00:25
overlookmotel added a commit that referenced this pull request Oct 28, 2024
Remove `well_known!` macro by expanding code manually.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from 3916cf0 to d2c418f Compare October 28, 2024 00:25
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from b7bf01b to 34b0e96 Compare October 28, 2024 00:39
overlookmotel added a commit that referenced this pull request Oct 28, 2024
Remove `well_known!` macro by expanding code manually.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from d2c418f to e2f01a1 Compare October 28, 2024 00:40
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 34b0e96 to 762ae5e Compare October 28, 2024 00:43
overlookmotel added a commit that referenced this pull request Oct 28, 2024
Remove `well_known!` macro by expanding code manually.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from e2f01a1 to 5166dea Compare October 28, 2024 00:44
Remove `well_known!` macro by expanding code manually.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 762ae5e to 54e78d9 Compare October 28, 2024 00:48
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_well_known_macro branch from 5166dea to 3aed3eb Compare October 28, 2024 00:48
Base automatically changed from 10-27-refactor_ast_tools_reduce_macro_usage to main October 28, 2024 00:56
@graphite-app graphite-app bot merged commit 3aed3eb into main Oct 28, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_remove_well_known_macro branch October 28, 2024 00:57
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
Remove `well_known!` macro by expanding code manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant