Skip to content

Comments

refactor(ast_tools): reduce macro usage#6956

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_reduce_macro_usage
Oct 28, 2024
Merged

refactor(ast_tools): reduce macro usage#6956
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_reduce_macro_usage

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

Pure refactor. Expand simple macros.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 15:24
@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior A-ast-tools Area - AST tools labels Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 93d291b to a50f77c Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from e7f19b8 to aafdaf6 Compare October 27, 2024 15:31
Copy link
Member Author

overlookmotel commented Oct 27, 2024

Merge activity

@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from a50f77c to 30f6eaa Compare October 27, 2024 19:02
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from aafdaf6 to 269d8ce Compare October 27, 2024 19:02
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 30f6eaa to fed06db Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 269d8ce to bf828f1 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from fed06db to 93bcac4 Compare October 27, 2024 19:31
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from bf828f1 to 15ea58e Compare October 27, 2024 19:31
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 93bcac4 to d9ac889 Compare October 27, 2024 23:49
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 15ea58e to 6e0f6ca Compare October 27, 2024 23:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from d9ac889 to 8c1c385 Compare October 28, 2024 00:08
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 6e0f6ca to 7b0aed4 Compare October 28, 2024 00:08
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 8c1c385 to 83d1f69 Compare October 28, 2024 00:24
overlookmotel added a commit that referenced this pull request Oct 28, 2024
Pure refactor. Expand simple macros.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 7b0aed4 to b7bf01b Compare October 28, 2024 00:25
Base automatically changed from 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ to main October 28, 2024 00:36
overlookmotel added a commit that referenced this pull request Oct 28, 2024
Pure refactor. Expand simple macros.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from b7bf01b to 34b0e96 Compare October 28, 2024 00:39
overlookmotel added a commit that referenced this pull request Oct 28, 2024
Pure refactor. Expand simple macros.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 34b0e96 to 762ae5e Compare October 28, 2024 00:43
Pure refactor. Expand simple macros.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_macro_usage branch from 762ae5e to 54e78d9 Compare October 28, 2024 00:48
@graphite-app graphite-app bot merged commit 54e78d9 into main Oct 28, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_reduce_macro_usage branch October 28, 2024 00:56
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant