Skip to content

Comments

refactor(ast_tools): replace str::replace with CowUtils::cow_replace#6954

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_
Oct 28, 2024
Merged

refactor(ast_tools): replace str::replace with CowUtils::cow_replace#6954
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

Obey our clippy-enforced policy to prefer CowUtils::cow_replace.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 27, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 27, 2024

CodSpeed Performance Report

Merging #6954 will not alter performance

Comparing 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ (83d1f69) with main (f5a7134)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 14:24
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from daa6e0a to 643e288 Compare October 27, 2024 14:33
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from b1250c4 to 7a15738 Compare October 27, 2024 14:33
Copy link
Member Author

overlookmotel commented Oct 27, 2024

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from 643e288 to efbdfa4 Compare October 27, 2024 15:23
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 7a15738 to 93d291b Compare October 27, 2024 15:23
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from efbdfa4 to 030e90d Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 93d291b to a50f77c Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from 030e90d to 2e4e127 Compare October 27, 2024 19:01
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from a50f77c to 30f6eaa Compare October 27, 2024 19:02
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from 2e4e127 to d20f85e Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 30f6eaa to fed06db Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from d20f85e to 11247b4 Compare October 27, 2024 19:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from fed06db to 93bcac4 Compare October 27, 2024 19:31
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from 11247b4 to 075f9bc Compare October 27, 2024 23:48
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 93bcac4 to d9ac889 Compare October 27, 2024 23:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from 075f9bc to 1495fe0 Compare October 28, 2024 00:08
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from d9ac889 to 8c1c385 Compare October 28, 2024 00:08
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
…ce` (#6954)

Obey our clippy-enforced policy to prefer `CowUtils::cow_replace`.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods branch from 1495fe0 to ac6b309 Compare October 28, 2024 00:24
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch from 8c1c385 to 83d1f69 Compare October 28, 2024 00:24
Base automatically changed from 10-27-refactor_ast_tools_remove_repeated_code_in_output_methods to main October 28, 2024 00:31
@graphite-app graphite-app bot merged commit 83d1f69 into main Oct 28, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_replace_str_replace_with_cowutils_cow_replace_ branch October 28, 2024 00:36
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
…ce` (oxc-project#6954)

Obey our clippy-enforced policy to prefer `CowUtils::cow_replace`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant