refactor(ast_tools): remove repeated code in Output methods#6953
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 28, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 27, 2024
This was referenced Oct 27, 2024
github-actions
bot
added
the
C-cleanup
This was referenced Oct 27, 2024
Member
Author
This was referenced Oct 27, 2024
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
7427d65 to
ce6cc38
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
daa6e0a to
643e288
Compare
Member
Author
Merge activity
|
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
ce6cc38 to
7535e9c
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
643e288 to
efbdfa4
Compare
This was referenced Oct 27, 2024
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
7535e9c to
8128308
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
efbdfa4 to
030e90d
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
8128308 to
7a5c0aa
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
030e90d to
2e4e127
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
7a5c0aa to
c78fab2
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
2e4e127 to
d20f85e
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
c78fab2 to
4add688
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
d20f85e to
11247b4
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
4add688 to
cf458c2
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
11247b4 to
075f9bc
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
cf458c2 to
ab308f5
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
075f9bc to
1495fe0
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_move_logger_into_separate_module
branch
from
ab308f5 to
2b10e5c
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
from
1495fe0 to
ac6b309
Compare
Base automatically changed from
10-27-refactor_ast_tools_move_logger_into_separate_module
to
main
October 28, 2024 00:28
graphite-app
bot
deleted the
10-27-refactor_ast_tools_remove_repeated_code_in_output_methods
branch
Orenbek
pushed a commit
to Orenbek/oxc
that referenced
this pull request
Oct 28, 2024
…oject#6953) `generator_path.replace('\\', "/")` was repeated in each module for that generates outputs. Move it, to reduce repetition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generator_path.replace('\\', "/")was repeated in each module for that generates outputs. Move it, to reduce repetition.