Skip to content

Comments

refactor(ast_tools): move logger into separate module#6952

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_move_logger_into_separate_module
Oct 28, 2024
Merged

refactor(ast_tools): move logger into separate module#6952
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_move_logger_into_separate_module

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024 •
edited
Loading

Reduce the amount of code in main.rs by moving logger functionality to a separate module.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Oct 27, 2024
Merged
Merged
Merged
@github-actions github-actions bot added the A-ast-tools Area - AST tools label Oct 27, 2024
This was referenced Oct 27, 2024
Merged
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 27, 2024
This was referenced Oct 27, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

This was referenced Oct 27, 2024
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 14:21
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 61c5627 to 71cfec9 Compare October 27, 2024 14:33
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from 7427d65 to ce6cc38 Compare October 27, 2024 14:33
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 27, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Oct 27, 10:33 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 10:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 11:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 8:01 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 8:06 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Oct 27, 8:23 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 8:28 PM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 71cfec9 to 4ed9067 Compare October 27, 2024 15:23
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from ce6cc38 to 7535e9c Compare October 27, 2024 15:23
This was referenced Oct 27, 2024
Merged
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 4ed9067 to 1dccaf2 Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from 7535e9c to 8128308 Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 1dccaf2 to 0d61e8b Compare October 27, 2024 19:00
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from 8128308 to 7a5c0aa Compare October 27, 2024 19:01
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 0d61e8b to a6badd5 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from 7a5c0aa to c78fab2 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from a6badd5 to 2f98776 Compare October 27, 2024 19:29
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from c78fab2 to 4add688 Compare October 27, 2024 19:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 2f98776 to 50073c9 Compare October 27, 2024 23:47
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from 4add688 to cf458c2 Compare October 27, 2024 23:48
@overlookmotel overlookmotel changed the base branch from 10-27-refactor_ast_tools_refactor_writing_outputs to graphite-base/6952 October 27, 2024 23:56
@graphite-app graphite-app bot changed the base branch from graphite-base/6952 to main October 28, 2024 00:05
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from cf458c2 to ab308f5 Compare October 28, 2024 00:08
@overlookmotel overlookmotel mentioned this pull request Oct 28, 2024
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 28, 2024
@overlookmotel
refactor(ast_tools): move logger into separate module (#6952)
2b10e5c 
Reduce the amount of code in `main.rs` by moving logger functionality to a separate module.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_move_logger_into_separate_module branch from ab308f5 to 2b10e5c Compare October 28, 2024 00:23
@overlookmotel overlookmotel mentioned this pull request Oct 28, 2024
Merged
@graphite-app graphite-app bot merged commit 2b10e5c into main Oct 28, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_move_logger_into_separate_module branch October 28, 2024 00:28
@overlookmotel overlookmotel mentioned this pull request Oct 28, 2024
Merged
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
@overlookmotel @Orenbek
refactor(ast_tools): move logger into separate module (oxc-project#6952)
92d52f7 
Reduce the amount of code in `main.rs` by moving logger functionality to a separate module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@overlookmotel