Skip to content

Comments

refactor(ast_tools): refactor writing outputs#6951

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_refactor_writing_outputs
Oct 28, 2024
Merged

refactor(ast_tools): refactor writing outputs#6951
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_refactor_writing_outputs

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

write_all_to no longer needs to be public. Remove it, and compact the code for writing files.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 27, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 14:20
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch from f1183a6 to dbdc766 Compare October 27, 2024 14:33
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 61c5627 to 71cfec9 Compare October 27, 2024 14:33
Copy link
Member

Boshen commented Oct 27, 2024

Merge activity

  • Oct 27, 10:33 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 10:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 11:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 11:44 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 11:50 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6945.
  • Oct 27, 11:50 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6945.
  • Oct 27, 7:39 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 7:56 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 8:04 PM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch from dbdc766 to 13809c8 Compare October 27, 2024 15:23
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 71cfec9 to 4ed9067 Compare October 27, 2024 15:23
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch from 13809c8 to aeb6515 Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 4ed9067 to 1dccaf2 Compare October 27, 2024 15:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch from aeb6515 to 356bde9 Compare October 27, 2024 19:00
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 1dccaf2 to 0d61e8b Compare October 27, 2024 19:00
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch from 356bde9 to 51ccd5b Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 0d61e8b to a6badd5 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch from 51ccd5b to 8abbb1b Compare October 27, 2024 19:28
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from a6badd5 to 2f98776 Compare October 27, 2024 19:29
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch 2 times, most recently from c963655 to 19d3a43 Compare October 27, 2024 23:47
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 2f98776 to 50073c9 Compare October 27, 2024 23:47
`write_all_to` no longer needs to be public. Remove it, and compact the code for writing files.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ branch from 19d3a43 to 6b88798 Compare October 27, 2024 23:56
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_refactor_writing_outputs branch from 50073c9 to 06f0565 Compare October 27, 2024 23:57
Base automatically changed from 10-27-refactor_ast_tools_generate_json_schema_as_output_raw_ to main October 28, 2024 00:03
@graphite-app graphite-app bot merged commit 06f0565 into main Oct 28, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_refactor_writing_outputs branch October 28, 2024 00:04
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
`write_all_to` no longer needs to be public. Remove it, and compact the code for writing files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants