Skip to content

Comments

refactor(ast_tools): hardcode schema output path#6949

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_hardcode_schema_output_path
Oct 27, 2024
Merged

refactor(ast_tools): hardcode schema output path#6949
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_hardcode_schema_output_path

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024 •
edited
Loading

Hard-code the output file path for JSON schema file. This will allow generating it as an Output, same as all other generated files.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Oct 27, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

This was referenced Oct 27, 2024
Merged
Merged
Merged
Merged
@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 27, 2024
This was referenced Oct 27, 2024
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 14:18
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_rename_output_into_raw_method branch from 12dd4a8 to a49ef71 Compare October 27, 2024 14:32
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_hardcode_schema_output_path branch from 47feb3f to 01ceac1 Compare October 27, 2024 14:33
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 27, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Oct 27, 10:33 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 10:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 11:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 11:41 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 11:50 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6945.
  • Oct 27, 11:50 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6945.
  • Oct 27, 7:39 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 7:40 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 7:46 PM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_rename_output_into_raw_method branch from a49ef71 to d7d1029 Compare October 27, 2024 15:22
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_hardcode_schema_output_path branch from 01ceac1 to 5cafc0f Compare October 27, 2024 15:22
This was referenced Oct 27, 2024
Merged
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_rename_output_into_raw_method branch from d7d1029 to 2c78454 Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_hardcode_schema_output_path branch from 5cafc0f to 71e5f69 Compare October 27, 2024 15:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_rename_output_into_raw_method branch from 2c78454 to fde9cf8 Compare October 27, 2024 18:58
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_hardcode_schema_output_path branch from 71e5f69 to 3a95d35 Compare October 27, 2024 18:59
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_rename_output_into_raw_method branch from fde9cf8 to 419ab60 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_hardcode_schema_output_path branch from 3a95d35 to 7b2dd13 Compare October 27, 2024 19:11
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_rename_output_into_raw_method branch 2 times, most recently from 1764b58 to 7c88a14 Compare October 27, 2024 19:28
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_hardcode_schema_output_path branch from 7b2dd13 to 55e0deb Compare October 27, 2024 19:28
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel
refactor(ast_tools): hardcode schema output path (#6949)
2fc6ca3 
Hard-code the output file path for JSON schema file. This will allow generating it as an `Output`, same as all other generated files.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_rename_output_into_raw_method branch from 7c88a14 to ef2f73e Compare October 27, 2024 23:41
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_hardcode_schema_output_path branch from 55e0deb to 2fc6ca3 Compare October 27, 2024 23:41
Base automatically changed from 10-27-refactor_ast_tools_rename_output_into_raw_method to main October 27, 2024 23:45
@graphite-app graphite-app bot merged commit 2fc6ca3 into main Oct 27, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_hardcode_schema_output_path branch October 27, 2024 23:46
This was referenced Oct 28, 2024
Merged
Merged
Merged
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
@overlookmotel @Orenbek
refactor(ast_tools): hardcode schema output path (oxc-project#6949)
c7a2ab3 
Hard-code the output file path for JSON schema file. This will allow generating it as an `Output`, same as all other generated files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@overlookmotel