Skip to content

Comments

refactor(ast_tools): add CI filter file to outputs#6946

Merged
overlookmotel merged 1 commit intomainfrom
10-27-refactor_ast_tools_add_ci_filter_file_to_outputs
Oct 27, 2024
Merged

refactor(ast_tools): add CI filter file to outputs#6946
overlookmotel merged 1 commit intomainfrom
10-27-refactor_ast_tools_add_ci_filter_file_to_outputs

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

Generate CI filter file as a RawOutput, same as the rest, rather than specific code to write it to a file.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

Copy link
Member Author

overlookmotel commented Oct 27, 2024

Merge activity

  • Oct 27, 10:32 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 10:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 11:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 11:39 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 11:50 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6945.
  • Oct 27, 11:50 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6945.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_simplify_logging branch from 81dbf5e to ad891a3 Compare October 27, 2024 15:22
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_add_ci_filter_file_to_outputs branch from ae3a36e to 5852fd0 Compare October 27, 2024 15:22
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_simplify_logging branch from ad891a3 to 63276ef Compare October 27, 2024 15:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_add_ci_filter_file_to_outputs branch from 5852fd0 to 7bfc6e3 Compare October 27, 2024 15:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_simplify_logging branch from 63276ef to d27ef6a Compare October 27, 2024 18:48
@overlookmotel overlookmotel changed the base branch from 10-27-refactor_ast_tools_simplify_logging to graphite-base/6946 October 27, 2024 18:53
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_add_ci_filter_file_to_outputs branch from 7bfc6e3 to f2319f5 Compare October 27, 2024 18:57
@overlookmotel overlookmotel changed the base branch from graphite-base/6946 to main October 27, 2024 18:58
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_add_ci_filter_file_to_outputs branch from f2319f5 to e054930 Compare October 27, 2024 18:58
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel merged commit 11539e6 into main Oct 27, 2024
@overlookmotel overlookmotel deleted the 10-27-refactor_ast_tools_add_ci_filter_file_to_outputs branch October 27, 2024 19:09
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
Generate CI filter file as a `RawOutput`, same as the rest, rather than
specific code to write it to a file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant