refactor(ast_tools): simplify logging#6945
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 27, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 27, 2024
Member
Author
This was referenced Oct 27, 2024
github-actions
bot
added
A-ast-tools
This was referenced Oct 27, 2024
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
from
9eecffa to
b5004e0
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_simplify_logging
branch
from
2211e0d to
81dbf5e
Compare
Member
Author
Merge activity
|
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
from
b5004e0 to
21b986e
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_simplify_logging
branch
from
81dbf5e to
ad891a3
Compare
This was referenced Oct 27, 2024
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
from
21b986e to
a75debe
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_simplify_logging
branch
from
ad891a3 to
63276ef
Compare
overlookmotel
changed the base branch from
10-27-refactor_ast_tools_combine_derives_into_generators
to
graphite-base/6945
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_simplify_logging
branch
from
63276ef to
d27ef6a
Compare
* Replace `logln!` macro with `log_result!` to log result of an action. * Move logging for writing files into one place.
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_simplify_logging
branch
from
d27ef6a to
87db9ee
Compare
graphite-app
bot
deleted the
10-27-refactor_ast_tools_simplify_logging
branch
This was referenced Oct 28, 2024
Orenbek
pushed a commit
to Orenbek/oxc
that referenced
this pull request
Oct 28, 2024
* Replace `logln!` macro with `log_result!` to log result of an action. * Move logging for writing files into one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logln!macro withlog_result!to log result of an action.