refactor(ast_tools): combine derives into generators#6944
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 27, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This was referenced Oct 27, 2024
github-actions
bot
added
A-ast-tools
This was referenced Oct 27, 2024
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_reduce_repeated_code
branch
from
682511b to
96d14a6
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
from
9eecffa to
b5004e0
Compare
Member
Author
Merge activity
|
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_reduce_repeated_code
branch
from
96d14a6 to
5d0104b
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
from
b5004e0 to
21b986e
Compare
This was referenced Oct 27, 2024
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_reduce_repeated_code
branch
from
5d0104b to
f813a37
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
from
21b986e to
a75debe
Compare
`Generator`s and `Derive`s now work the same. Combine them into a single `Vec`.
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_reduce_repeated_code
branch
from
f813a37 to
80a163e
Compare
overlookmotel
force-pushed
the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
from
a75debe to
dde095c
Compare
Base automatically changed from
10-27-refactor_ast_tools_reduce_repeated_code
to
main
October 27, 2024 15:47
graphite-app
bot
deleted the
10-27-refactor_ast_tools_combine_derives_into_generators
branch
This was referenced Oct 28, 2024
Orenbek
pushed a commit
to Orenbek/oxc
that referenced
this pull request
Oct 28, 2024
`Generator`s and `Derive`s now work the same. Combine them into a single `Vec`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generators andDerives now work the same. Combine them into a singleVec.