Skip to content

Comments

refactor(ast_tools): reduce repeated code#6943

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_reduce_repeated_code
Oct 27, 2024
Merged

refactor(ast_tools): reduce repeated code#6943
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_reduce_repeated_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

Use one function to process all passes.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 27, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 14:10
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_all_runners_produce_vec_output_ branch from 6b4fb05 to 0dfce2a Compare October 27, 2024 14:32
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_repeated_code branch from 682511b to 96d14a6 Compare October 27, 2024 14:32
Copy link
Member Author

overlookmotel commented Oct 27, 2024

Merge activity

  • Oct 27, 10:32 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 10:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6942.
  • Oct 27, 11:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 11:37 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 11:47 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_all_runners_produce_vec_output_ branch from 0dfce2a to a277748 Compare October 27, 2024 15:22
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_repeated_code branch from 96d14a6 to 5d0104b Compare October 27, 2024 15:22
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
Base automatically changed from 10-27-refactor_ast_tools_all_runners_produce_vec_output_ to main October 27, 2024 15:29
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_repeated_code branch from 5d0104b to f813a37 Compare October 27, 2024 15:30
Use one function to process all passes.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_reduce_repeated_code branch from f813a37 to 80a163e Compare October 27, 2024 15:37
@graphite-app graphite-app bot merged commit 80a163e into main Oct 27, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_reduce_repeated_code branch October 27, 2024 15:47
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant