Skip to content

Comments

refactor(ast_tools): all runners produce Vec<Output>#6942

Merged
overlookmotel merged 1 commit intomainfrom
10-27-refactor_ast_tools_all_runners_produce_vec_output_
Oct 27, 2024
Merged

refactor(ast_tools): all runners produce Vec<Output>#6942
overlookmotel merged 1 commit intomainfrom
10-27-refactor_ast_tools_all_runners_produce_vec_output_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

Standardize all the different Runners to produce Vec<Output>.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 27, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 14:09
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_simplify_pass_ branch from bf6379a to e7a83cc Compare October 27, 2024 14:32
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_all_runners_produce_vec_output_ branch from 6b4fb05 to 0dfce2a Compare October 27, 2024 14:32
Copy link
Member Author

overlookmotel commented Oct 27, 2024

Merge activity

  • Oct 27, 10:32 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 10:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 10:54 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.

@overlookmotel overlookmotel changed the base branch from 10-27-refactor_ast_tools_simplify_pass_ to graphite-base/6942 October 27, 2024 14:38
@graphite-app graphite-app bot changed the base branch from graphite-base/6942 to main October 27, 2024 14:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_all_runners_produce_vec_output_ branch from 0dfce2a to a277748 Compare October 27, 2024 15:22
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
@overlookmotel overlookmotel merged commit e1b747d into main Oct 27, 2024
@overlookmotel overlookmotel deleted the 10-27-refactor_ast_tools_all_runners_produce_vec_output_ branch October 27, 2024 15:29
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
)

Standardize all the different `Runner`s to produce `Vec<Output>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant