Skip to content

Comments

refactor(ast_tools): simplify Pass#6941

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_simplify_pass_
Oct 27, 2024
Merged

refactor(ast_tools): simplify Pass#6941
graphite-app[bot] merged 1 commit intomainfrom
10-27-refactor_ast_tools_simplify_pass_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 27, 2024

Pure refactor. Remove dead code and structure like the other Runners.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 27, 2024

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 27, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 27, 2024 14:08
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2024
Base automatically changed from 10-27-refactor_ast_tools_clarify_code to main October 27, 2024 14:30
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_simplify_pass_ branch from bf6379a to e7a83cc Compare October 27, 2024 14:32
Copy link
Member Author

overlookmotel commented Oct 27, 2024

Merge activity

  • Oct 27, 10:32 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 10:38 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 27, 10:51 AM EDT: A user merged this pull request with the Graphite merge queue.

Pure refactor. Remove dead code and structure like the other `Runner`s.
@overlookmotel overlookmotel force-pushed the 10-27-refactor_ast_tools_simplify_pass_ branch from e7a83cc to c83b758 Compare October 27, 2024 14:38
@graphite-app graphite-app bot merged commit c83b758 into main Oct 27, 2024
@graphite-app graphite-app bot deleted the 10-27-refactor_ast_tools_simplify_pass_ branch October 27, 2024 14:51
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
Pure refactor. Remove dead code and structure like the other `Runner`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant