Skip to content

Comments

refactor(ast_tools): shorten code in Visit generator#6928

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-26-refactor_ast_tools_shorten_code_in_visit_generator
Oct 26, 2024
Merged

refactor(ast_tools): shorten code in Visit generator#6928
graphite-app[bot] merged 1 commit intomainfrom
10-26-refactor_ast_tools_shorten_code_in_visit_generator

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 26, 2024

Remove double line-break which formatting removes anyway.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 26, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 26, 2024 14:00
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 26, 2024
Copy link
Member Author

overlookmotel commented Oct 26, 2024

Merge activity

  • Oct 26, 10:02 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 26, 10:04 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 26, 10:17 AM EDT: A user merged this pull request with the Graphite merge queue.

Remove double line-break which formatting removes anyway.
@overlookmotel overlookmotel force-pushed the 10-26-refactor_ast_tools_remove_const_params_for_visit_generator branch from 75a31c9 to ad40ab7 Compare October 26, 2024 14:07
@overlookmotel overlookmotel force-pushed the 10-26-refactor_ast_tools_shorten_code_in_visit_generator branch from fdb6ee8 to 345b0a6 Compare October 26, 2024 14:07
Base automatically changed from 10-26-refactor_ast_tools_remove_const_params_for_visit_generator to main October 26, 2024 14:16
@graphite-app graphite-app bot merged commit 345b0a6 into main Oct 26, 2024
@graphite-app graphite-app bot deleted the 10-26-refactor_ast_tools_shorten_code_in_visit_generator branch October 26, 2024 14:17
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
)

Remove double line-break which formatting removes anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant