Skip to content

Comments

chore(transform_conformance): reorganize react-refresh related tests#6918

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-26-chore_transform_conformance_reorganize_react-refresh_related_tests
Oct 26, 2024
Merged

chore(transform_conformance): reorganize react-refresh related tests#6918
graphite-app[bot] merged 1 commit intomainfrom
10-26-chore_transform_conformance_reorganize_react-refresh_related_tests

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 26, 2024

Move all tests that are copied from react-refresh to the react-refresh directory, and add a README to describe the source of these tests. This way we can better stay in sync with upstream.

related: #6884 (comment)

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 26, 2024
@Dunqing Dunqing force-pushed the 10-26-chore_transform_conformance_reorganize_react-refresh_related_tests branch from d95bf49 to 8e2e0c9 Compare October 26, 2024 10:43
@Dunqing Dunqing requested a review from overlookmotel October 26, 2024 10:43
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for doing this.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 26, 2024
Copy link
Member

overlookmotel commented Oct 26, 2024

Merge activity

  • Oct 26, 9:06 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 26, 9:06 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 26, 9:11 AM EDT: A user merged this pull request with the Graphite merge queue.

…6918)

Move all tests that are copied from [react-refresh](https://github.com/facebook/react/blob/main/packages/react-refresh/src/__tests__/ReactFreshBabelPlugin-test.js) to the `react-refresh` directory, and add a README to describe the source of these tests. This way we can better stay in sync with upstream.

related: #6884 (comment)
@overlookmotel overlookmotel force-pushed the 10-26-chore_transform_conformance_reorganize_react-refresh_related_tests branch from 8e2e0c9 to 142da1d Compare October 26, 2024 13:07
@graphite-app graphite-app bot merged commit 142da1d into main Oct 26, 2024
@graphite-app graphite-app bot deleted the 10-26-chore_transform_conformance_reorganize_react-refresh_related_tests branch October 26, 2024 13:11
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
…xc-project#6918)

Move all tests that are copied from [react-refresh](https://github.com/facebook/react/blob/main/packages/react-refresh/src/__tests__/ReactFreshBabelPlugin-test.js) to the `react-refresh` directory, and add a README to describe the source of these tests. This way we can better stay in sync with upstream.

related: oxc-project#6884 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants