feat(napi/parser)!: add typings to napi/parser by ottomated · Pull Request #6796 · oxc-project/oxc

ottomated · 2024-10-23T02:47:10Z

Added TypeScript annotation for ParseResult.program
Modified the entrypoint for oxc-parser to allow wrapping the napi functions
Updated index.js to parse the program string into a JSON object
Updated tests
Added a dependency on @oxc/types

graphite-app · 2024-10-23T02:47:14Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

ottomated · 2024-10-23T02:47:24Z

feat(napi/parser)!: add typings to napi/parser #6796 👈
feat(ast_tools): output typescript to a separate package #6755
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ottomated and the rest of your teammates on Graphite

codspeed-hq · 2024-10-23T02:55:56Z

CodSpeed Performance Report

Merging #6796 will not alter performance

_{Comparing 10-22-feat_add_types_to_napi_parser (67a7bde) with main (1c27a2c)}

Summary

✅ 30 untouched benchmarks

napi/parser/index.js

napi/parser/package.json

npm/oxc-parser/package.json

napi/parser/package.json

overlookmotel · 2024-10-23T17:07:57Z

Note: This PR is a breaking change to oxc-parser package, as parseSync and parseAsync now return the AST as a JS object, rather than JSON string. That change is good (#4295), but we should make sure it's released with suitable semver bump.

overlookmotel

NPM package README should be updated to reflect the API change.

https://github.com/oxc-project/oxc/blob/main/npm/oxc-parser/README.md

(please rebase on top of #6834 once its merged, to avoid merge conflicts)

overlookmotel

Please update dprint config to add bindings.js to the exclusion list (and remove index.js).

That'll stop autofix CI job repeatedly reformatting NAPI-RS's generated code.

napi/parser/index.js

overlookmotel

This should be the last round of change requests!

napi/parser/bindings.js

npm/oxc-parser/.gitignore

tasks/ast_tools/src/generators/typescript.rs

overlookmotel

Great! All we need to do is resolve question of what package name to publish the types under, and we're good to go.

overlookmotel · 2024-10-23T22:03:31Z

Note: Merge #6836 too after merging this.

Boshen · 2024-10-24T13:07:40Z

Merge activity

Oct 24, 9:07 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 24, 9:08 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 24, 9:15 AM EDT: A user merged this pull request with the Graphite merge queue.

- Added TypeScript annotation for `ParseResult.program` - Modified the entrypoint for `oxc-parser` to allow wrapping the napi functions - Updated `index.js` to parse the `program` string into a JSON object - Updated tests - Added a dependency on `@oxc/types`

Dunqing · 2024-10-24T13:27:02Z

We don't have oxc scope in NPM if I remember correctly @Boshen cc

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen) - 686727f minifier: Reference read has side effect (#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (#6848) (Dunqing) - b075982 types: Change @oxc/types package name (#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (#6890) (overlookmotel) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

- Added TypeScript annotation for `ParseResult.program` - Modified the entrypoint for `oxc-parser` to allow wrapping the napi functions - Updated `index.js` to parse the `program` string into a JSON object - Updated tests - Added a dependency on `@oxc/types`

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (oxc-project#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (oxc-project#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (oxc-project#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (oxc-project#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (oxc-project#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (oxc-project#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (oxc-project#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (oxc-project#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (oxc-project#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (oxc-project#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (oxc-project#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (oxc-project#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (oxc-project#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (oxc-project#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen) - 686727f minifier: Reference read has side effect (oxc-project#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (oxc-project#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (oxc-project#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (oxc-project#6848) (Dunqing) - b075982 types: Change @oxc/types package name (oxc-project#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (oxc-project#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (oxc-project#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (oxc-project#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (oxc-project#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (oxc-project#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (oxc-project#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (oxc-project#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (oxc-project#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (oxc-project#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (oxc-project#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (oxc-project#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (oxc-project#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (oxc-project#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (oxc-project#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (oxc-project#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (oxc-project#6890) (overlookmotel) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

ottomated mentioned this pull request Oct 23, 2024

feat(ast_tools): output typescript to a separate package #6755

Merged

ottomated requested a review from overlookmotel October 23, 2024 02:48

ottomated marked this pull request as ready for review October 23, 2024 02:49

Boshen changed the title ~~make oxc-parser type-safe~~ parser: add typings to napi/parser Oct 23, 2024

ottomated changed the title ~~parser: add typings to napi/parser~~ feat: add typings to napi/parser Oct 23, 2024

ottomated changed the title ~~feat: add typings to napi/parser~~ feat(napi/parser): add typings to napi/parser Oct 23, 2024

github-actions bot added the C-enhancement Category - New feature or request label Oct 23, 2024

overlookmotel requested changes Oct 23, 2024

View reviewed changes

napi/parser/index.js Outdated Show resolved Hide resolved

napi/parser/package.json Outdated Show resolved Hide resolved

npm/oxc-parser/package.json Outdated Show resolved Hide resolved

napi/parser/package.json Outdated Show resolved Hide resolved

overlookmotel mentioned this pull request Oct 23, 2024

oxc-parser NPM package return AST as JS object, not JSON #4295

Closed

overlookmotel changed the title ~~feat(napi/parser): add typings to napi/parser~~ feat(napi/parser)!: add typings to napi/parser Oct 23, 2024

overlookmotel requested changes Oct 23, 2024

View reviewed changes

overlookmotel reviewed Oct 23, 2024

View reviewed changes

napi/parser/index.js Outdated Show resolved Hide resolved

github-actions bot added the A-ast-tools Area - AST tools label Oct 23, 2024

overlookmotel mentioned this pull request Oct 23, 2024

docs(napi): Remove JSON.parse from example #6836

Merged

ottomated requested a review from overlookmotel October 23, 2024 19:20

overlookmotel requested changes Oct 23, 2024

View reviewed changes

napi/parser/bindings.js Outdated Show resolved Hide resolved

npm/oxc-parser/.gitignore Show resolved Hide resolved

tasks/ast_tools/src/generators/typescript.rs Outdated Show resolved Hide resolved

ottomated requested a review from overlookmotel October 23, 2024 20:50

overlookmotel approved these changes Oct 23, 2024

View reviewed changes

Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 24, 2024

Boshen force-pushed the 10-21-feat_output_typescript_to_a_separate_package branch from f51b1f5 to 1145341 Compare October 24, 2024 13:09

Boshen force-pushed the 10-22-feat_add_types_to_napi_parser branch from 7ee18ed to 67a7bde Compare October 24, 2024 13:09

Base automatically changed from 10-21-feat_output_typescript_to_a_separate_package to main October 24, 2024 13:13

graphite-app bot merged commit 67a7bde into main Oct 24, 2024

graphite-app bot deleted the 10-22-feat_add_types_to_napi_parser branch October 24, 2024 13:15

overlookmotel mentioned this pull request Oct 24, 2024

Release new @oxc-project/types NPM package #6862

Closed

oxc-bot mentioned this pull request Oct 26, 2024

release(crates): v0.34.0 #6908

Merged

Uh oh!

Comments

Conversation

ottomated commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

ottomated commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #6796 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel commented Oct 23, 2024

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

overlookmotel commented Oct 23, 2024

Uh oh!

Boshen commented Oct 24, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Dunqing commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ottomated commented Oct 23, 2024 •

edited

Loading

ottomated commented Oct 23, 2024 •

edited

Loading

codspeed-hq bot commented Oct 23, 2024 •

edited

Loading

Boshen commented Oct 24, 2024 •

edited by graphite-app bot

Loading