Skip to content

Comments

fix(linter): remove unsafe fixer of no-useless-spread#6655

Merged
Boshen merged 3 commits intooxc-project:mainfrom
shulaoda:fix/linter-no-useless-spread
Oct 28, 2024
Merged

fix(linter): remove unsafe fixer of no-useless-spread#6655
Boshen merged 3 commits intooxc-project:mainfrom
shulaoda:fix/linter-no-useless-spread

Conversation

@shulaoda
Copy link
Contributor

closes #6618

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Oct 18, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #6655 will not alter performance

Comparing shulaoda:fix/linter-no-useless-spread (b6af37a) with main (56f5506)

Summary

✅ 30 untouched benchmarks

@shulaoda shulaoda marked this pull request as draft October 18, 2024 09:47
@DonIsaac
Copy link
Contributor

In this case, we should mark the fix as dangerous instead of skipping it entirely

@shulaoda shulaoda force-pushed the fix/linter-no-useless-spread branch from e9d964c to 4dfefe1 Compare October 19, 2024 09:27
@shulaoda shulaoda marked this pull request as ready for review October 19, 2024 14:58
@shulaoda shulaoda requested a review from camc314 October 19, 2024 15:00
@Boshen Boshen self-assigned this Oct 22, 2024
@shulaoda shulaoda force-pushed the fix/linter-no-useless-spread branch from 9871a55 to d30564c Compare October 24, 2024 13:00
@Boshen Boshen force-pushed the fix/linter-no-useless-spread branch from d30564c to b6af37a Compare October 28, 2024 09:06
@Boshen Boshen merged commit 7aa496a into oxc-project:main Oct 28, 2024
@shulaoda shulaoda deleted the fix/linter-no-useless-spread branch October 28, 2024 10:10
@oxc-bot oxc-bot mentioned this pull request Nov 3, 2024
Boshen added a commit that referenced this pull request Nov 3, 2024
## [0.11.0] - 2024-11-03

- 9fd9f4f linter: [**BREAKING**] Sync sindresorhus/globals; removed
Object.prototype properties from builtin and es* globals (#6991)
(Boshen)

### Features

- 6b619da editor: Listen to config file changes and trigger a
didChangeConfiguration update (#6964) (Nicholas Rayburn)
- 7872927 editor/vscode: Support window/showMessage event (#7085)
(Nicholas Rayburn)
- 2184588 linter: Do not bail for unmatched rules yet (#7093) (Boshen)
- a6fcd81 linter: Add `import/no-commonjs` rule (#6978) (Dmitry
Zakharov)
- 1691cab linter: Support user-configurable secrets for
`oxc-security/api-keys` (#5938) (DonIsaac)
- 610621c linter: Implement `react/style-prop-object` (#6342) (Albert
Kaaman)
- 1e2f012 linter: Add `oxc/no-map-spread` (#6751) (DonIsaac)
- 1c66473 linter: Implement `eslint/prefer-object-has-own` (#6905)
(tomoya yanagibashi)

### Bug Fixes

- ebf3753 editor: Fix onConfigChange to send the correct config for
didChangeConfiguration notification (#6962) (Nicholas Rayburn)
- 79bf74a linter: Check is_reference_to_global_variable in
`no-array-constructor` (#7067) (Naoya Yoshizawa)
- 38d1f78 linter: Remove confusing help text for now (#7081) (Cam
McHenry)
- 147e2e4 linter: Allow replacing rule when none are enabled yet (#7014)
(camchenry)
- 7aa496a linter: Remove unsafe fixer of `no-useless-spread` (#6655)
(dalaoshu)
- f5a7134 linter/no-unused-vars: False positive for discarded reads
within sequences (#6907) (DonIsaac)

### Documentation

- 4551baa linter: Document `rules` (#6983) (Boshen)

### Refactor

- a8dc75d linter: Remove unused CLI result types (#7088) (camchenry)
- 8f1460e linter: Move `LintPlugins` from `LintOptions` to `LintConfig`
(#6932) (DonIsaac)

### Testing

- c35d3f2 linter: Improve test failure output (#6975) (camchenry)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: unsafe fixer in no-useless-spread

4 participants