Merged
Conversation
Contributor
Benchmark ResultsLinuxWindows |
Boshen
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
AstKind::debug_name(), which returns the name of an AstKind struct with a few minor details as applicable. I intentionally did not makeAstKindimplementDisplay, as this method returns minimal information. Additionally, this method only exists in debug builds. I've hidden it behind a#[cfg(debug_assertions)], so it won't affect release builds.This code was extracted from #642, where it as created while debugging iteration over ancestor nodes. I figured it belonged in its own PR and may be useful to other devs.