fix(linter): no-else-return fixer fails when else has no trailing whitespace#6348
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 7, 2024
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #6348 will not alter performanceComparing Summary
|
DonIsaac
changed the title
no_else_return fixer fails when else has no trailing whitespaceno-else-return fixer fails when else has no trailing whitespace
camc314
approved these changes
Oct 7, 2024
Contributor
Merge activity
|
… whitespace (#6348) Fixes a bug in `eslint/no_else_return`'s fixer where fixes were not being property applied when `else` had no whitespace immediately after it. For example: ```js if(x){ return x }else{ return y } ``` I also refactored the rule's fixer to avoid string allocations as much as possible.
DonIsaac
force-pushed
the
don/10-07-fix_linter_no_else_return_fixer_fails_when_else_has_no_trailing_whitespace
branch
from
1ade3c3 to
71ad5d3
Compare
graphite-app
bot
deleted the
don/10-07-fix_linter_no_else_return_fixer_fails_when_else_has_no_trailing_whitespace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
eslint/no_else_return's fixer where fixes were not beingproperty applied when
elsehad no whitespace immediately after it. Forexample:
I also refactored the rule's fixer to avoid string allocations as much as
possible.