Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

• fix(semantic): enter scope after check_type for TSConditionalType #6270 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

CodSpeed Performance Report

Merging #6270 will not alter performance

_{Comparing don/10-03-fix_semantic_enter_scope_after_check_type_for_tsconditionaltype (3556148) with main (2f888ed)}

Summary

✅ 29 untouched benchmarks

The usual drill for this is @Dunqing will dig into tsc to find the matching resolution code. He's on holiday so we'll have to wait a bit.

Ideally we'd update ast_tools to let us configure the order of enter/leave scopes.

You can (and should). Add #[scope(enter_before)] to the extends_type field. Same as it is in TSEnumDeclaration:

If you do that, ast_tools will update Visit and VisitMut automatically, and you don't need to add visit_ts_conditional_type method to impl<'a> Visit<'a> for SemanticBuilder<'a>. It'll also make Traverse enter the scope at the right point.

Note: Run just ast to run ast_tools codegen after adding the attribute.

Ideally we'd update ast_tools to let us configure the order of enter/leave scopes.

You can (and should). Add #[scope(enter_before)] to the extends_type field. Same as it is in TSEnumDeclaration:

oxc/crates/oxc_ast/src/ast/ts.rs

Lines 85 to 90 in 50a0029

	pub struct TSEnumDeclaration<'a> {
	#[serde(flatten)]
	pub span: Span,
	pub id: BindingIdentifier<'a>,
	#[scope(enter_before)]
	pub members: Vec<'a, TSEnumMember<'a>>,

If you do that, ast_tools will update Visit and VisitMut automatically, and you don't need to add visit_ts_conditional_type method to impl<'a> Visit<'a> for SemanticBuilder<'a>. It'll also make Traverse enter the scope at the right point.

Note: Run just ast to run ast_tools codegen after adding the attribute.

Is there also an #[scope(exit_after)]?

Is there also an #[scope(exit_after)]?

No. We haven't found a use for that. But it wouldn't be hard to add if we need it.

We need that to exit the scope before the false branch, since inferred type parameters (e.g. infer R) are only in scope within the true branch.

Closed in favor of #6351