perf(transformer): speed up searching for position to insert new statements#6189
Closed
overlookmotel wants to merge 2 commits intomainfrom
Closed
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Sep 30, 2024
Member
Author
This was referenced Sep 30, 2024
CodSpeed Performance ReportMerging #6189 will not alter performanceComparing Summary
|
Member
Author
|
Hard to see exactly with the noise in the benchmarks, but looks like this hurts perf, rather than improving it. I'll take another look. |
925ae2d to
766da5b
Compare
766da5b to
b310e7c
Compare
8c05f2a to
825e3b8
Compare
b310e7c to
3c8b255
Compare
3c8b255 to
8eb27ca
Compare
825e3b8 to
da2b2a4
Compare
8eb27ca to
73df633
Compare
73df633 to
f028e3c
Compare
Member
Author
|
I give up. You'd think this would be better, but it appears it's not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

To pass Babel's tests, we have to insert new statements after any existing
importstatements.Currently we find the insert position by searching backwards from the end of the file for the last
importstatement. But for a large file, that's a lot of statements to search through. Instead, search from the start for the first statement which is not animport, and insert before it.Pass one annoying Babel test case by also checking for case where file starts with a non-
importstatement, but then hasimportstatements after it.If the file is a script, can skip searching entirely, as only modules can contain
importstatements.