Skip to content

Comments

ci(transformer): run transformer tests under Miri#6112

Merged
overlookmotel merged 1 commit intomainfrom
09-27-ci_transformer_run_transformer_tests_under_miri
Sep 27, 2024
Merged

ci(transformer): run transformer tests under Miri#6112
overlookmotel merged 1 commit intomainfrom
09-27-ci_transformer_run_transformer_tests_under_miri

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 27, 2024

Transformer tests include tests for unsafe code in Stack and NonEmptyStack. Run these tests under Miri.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Sep 27, 2024

@overlookmotel overlookmotel marked this pull request as ready for review September 27, 2024 13:26
@overlookmotel overlookmotel force-pushed the 09-27-refactor_smeantic_fix_lint_warning_in_nightly branch from b29566a to a294833 Compare September 27, 2024 13:28
@overlookmotel overlookmotel force-pushed the 09-27-ci_transformer_run_transformer_tests_under_miri branch from ad88ab7 to 645c373 Compare September 27, 2024 13:28
@overlookmotel overlookmotel changed the base branch from 09-27-refactor_smeantic_fix_lint_warning_in_nightly to graphite-base/6112 September 27, 2024 13:45
@overlookmotel
Copy link
Member Author

overlookmotel commented Sep 27, 2024

@Boshen Miri CI job goes from 3m30s to 4m10s (Miri so slow). Is that a problem? If we want to keep it down to minimum, we could shard it?

Note: Once we have removed the last AstBuilder::copy calls, it'd be good to add more tests to oxc_transformer that exercise Traverse and run those tests under Miri. So this isn't purely to run Miri on Stack.

@overlookmotel overlookmotel force-pushed the 09-27-ci_transformer_run_transformer_tests_under_miri branch from 645c373 to 084ecf9 Compare September 27, 2024 13:49
@overlookmotel overlookmotel changed the base branch from graphite-base/6112 to main September 27, 2024 13:50
@overlookmotel overlookmotel force-pushed the 09-27-ci_transformer_run_transformer_tests_under_miri branch from 084ecf9 to 6f63b77 Compare September 27, 2024 13:50
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Merge activity

  • Sep 27, 11:55 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 27, 12:28 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@overlookmotel overlookmotel merged commit 509460b into main Sep 27, 2024
@overlookmotel overlookmotel deleted the 09-27-ci_transformer_run_transformer_tests_under_miri branch September 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants