Skip to content

Comments

refactor(semantic): fix lint warning in nightly#6110

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-27-refactor_smeantic_fix_lint_warning_in_nightly
Sep 27, 2024
Merged

refactor(semantic): fix lint warning in nightly#6110
graphite-app[bot] merged 1 commit intomainfrom
09-27-refactor_smeantic_fix_lint_warning_in_nightly

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 27, 2024

Fix a lint warning which you only get on nightly (so appears when running Miri).

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Sep 27, 2024

@github-actions github-actions bot added the A-semantic Area - Semantic label Sep 27, 2024
@overlookmotel overlookmotel changed the title refactor(smeantic): fix lint warning in nightly refactor(semantic): fix lint warning in nightly Sep 27, 2024
@overlookmotel overlookmotel marked this pull request as ready for review September 27, 2024 13:20
@overlookmotel overlookmotel force-pushed the 09-27-refactor_smeantic_fix_lint_warning_in_nightly branch from c3f2ba3 to b29566a Compare September 27, 2024 13:24
@overlookmotel overlookmotel changed the base branch from main to 09-27-docs_transformer_fix_formatting_of_readme September 27, 2024 13:24
Base automatically changed from 09-27-docs_transformer_fix_formatting_of_readme to main September 27, 2024 13:27
@overlookmotel overlookmotel force-pushed the 09-27-refactor_smeantic_fix_lint_warning_in_nightly branch from b29566a to a294833 Compare September 27, 2024 13:28
@overlookmotel
Copy link
Member Author

Minor change so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Merge activity

  • Sep 27, 9:44 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 27, 9:44 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 27, 9:49 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.

Fix a lint warning which you only get on nightly (so appears when running Miri).
@overlookmotel overlookmotel force-pushed the 09-27-refactor_smeantic_fix_lint_warning_in_nightly branch from a294833 to 2090fce Compare September 27, 2024 13:45
@graphite-app graphite-app bot merged commit 2090fce into main Sep 27, 2024
@graphite-app graphite-app bot deleted the 09-27-refactor_smeantic_fix_lint_warning_in_nightly branch September 27, 2024 13:49
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2024

CodSpeed Performance Report

Merging #6110 will not alter performance

Comparing 09-27-refactor_smeantic_fix_lint_warning_in_nightly (2090fce) with main (fd6798f)

Summary

✅ 29 untouched benchmarks

Boshen added a commit that referenced this pull request Sep 28, 2024
## [0.30.4] - 2024-09-28

### Bug Fixes

- 8582ae3 codegen: Missing parentheses if there is a pure comment before
a NewExpression as a ComputedMemberExpression's callee (#6105) (Dunqing)
- fd6798f parser: Remove unintended `pub Kind` (#6109) (Boshen)
- 6f98aad sourcemap: Align sourcemap type with Rollup (#6133) (Boshen)
- 64d4756 transformer: Fix debug assertion in `Stack` (#6106)
(overlookmotel)

### Performance

- 05852a0 codegen: Do not check whether there are annotation comments or
not if we don't preserve annotation comments (#6107) (Dunqing)

### Documentation

- 26a273a oxc-transform: Update README (Boshen)
- e2c5baf transformer: Fix formatting of README (#6111) (overlookmotel)

### Refactor

- 2090fce semantic: Fix lint warning in nightly (#6110) (overlookmotel)
- 7bc3988 transformer: Remove dead code (#6124) (overlookmotel)
- 07fe45b transformer: Exponentiation operator: convert to match (#6123)
(overlookmotel)
- 4387845 transformer: Share `TypeScriptOptions` with ref not `Rc`
(#6121) (overlookmotel)
- 09e41c2 transformer: Share `TransformCtx` with ref not `Rc` (#6118)
(overlookmotel)
- 58fd6eb transformer: Pre-allocate more stack space (#6095)
(overlookmotel)
- 9ac80bd transformer: Add wrapper around `NonNull` (#6115)
(overlookmotel)
- c50500e transformer: Move common stack functionality into
`StackCommon` trait (#6114) (overlookmotel)
- 9839059 transformer: Simplify `StackCapacity` trait (#6113)
(overlookmotel)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant