Skip to content

Comments

perf(codegen): do not check whether there are annotation comments or not if we don't preserve annotation comments#6107

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-27-pref_codegen_do_not_check_whether_there_are_annotation_comments_or_not_if_we_don_t_preserve_annotation_comments
Sep 27, 2024
Merged

perf(codegen): do not check whether there are annotation comments or not if we don't preserve annotation comments#6107
graphite-app[bot] merged 1 commit intomainfrom
09-27-pref_codegen_do_not_check_whether_there_are_annotation_comments_or_not_if_we_don_t_preserve_annotation_comments

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 27, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Sep 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-codegen Area - Code Generation label Sep 27, 2024
@Dunqing Dunqing changed the title pref(codegen): do not check whether there are annotation comments or not if we don't preserve annotation comments perf(codegen): do not check whether there are annotation comments or not if we don't preserve annotation comments Sep 27, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2024

CodSpeed Performance Report

Merging #6107 will not alter performance

Comparing 09-27-pref_codegen_do_not_check_whether_there_are_annotation_comments_or_not_if_we_don_t_preserve_annotation_comments (05852a0) with main (8582ae3)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Merge activity

  • Sep 27, 7:18 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 27, 7:18 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 27, 7:23 AM EDT: Boshen merged this pull request with the Graphite merge queue.

…not if we don't preserve annotation comments (#6107)
@Boshen Boshen force-pushed the 09-27-pref_codegen_do_not_check_whether_there_are_annotation_comments_or_not_if_we_don_t_preserve_annotation_comments branch from f468da1 to 05852a0 Compare September 27, 2024 11:18
@graphite-app graphite-app bot merged commit 05852a0 into main Sep 27, 2024
@graphite-app graphite-app bot deleted the 09-27-pref_codegen_do_not_check_whether_there_are_annotation_comments_or_not_if_we_don_t_preserve_annotation_comments branch September 27, 2024 11:23
Boshen added a commit that referenced this pull request Sep 28, 2024
## [0.30.4] - 2024-09-28

### Bug Fixes

- 8582ae3 codegen: Missing parentheses if there is a pure comment before
a NewExpression as a ComputedMemberExpression's callee (#6105) (Dunqing)
- fd6798f parser: Remove unintended `pub Kind` (#6109) (Boshen)
- 6f98aad sourcemap: Align sourcemap type with Rollup (#6133) (Boshen)
- 64d4756 transformer: Fix debug assertion in `Stack` (#6106)
(overlookmotel)

### Performance

- 05852a0 codegen: Do not check whether there are annotation comments or
not if we don't preserve annotation comments (#6107) (Dunqing)

### Documentation

- 26a273a oxc-transform: Update README (Boshen)
- e2c5baf transformer: Fix formatting of README (#6111) (overlookmotel)

### Refactor

- 2090fce semantic: Fix lint warning in nightly (#6110) (overlookmotel)
- 7bc3988 transformer: Remove dead code (#6124) (overlookmotel)
- 07fe45b transformer: Exponentiation operator: convert to match (#6123)
(overlookmotel)
- 4387845 transformer: Share `TypeScriptOptions` with ref not `Rc`
(#6121) (overlookmotel)
- 09e41c2 transformer: Share `TransformCtx` with ref not `Rc` (#6118)
(overlookmotel)
- 58fd6eb transformer: Pre-allocate more stack space (#6095)
(overlookmotel)
- 9ac80bd transformer: Add wrapper around `NonNull` (#6115)
(overlookmotel)
- c50500e transformer: Move common stack functionality into
`StackCommon` trait (#6114) (overlookmotel)
- 9839059 transformer: Simplify `StackCapacity` trait (#6113)
(overlookmotel)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants