Skip to content

Comments

fix(linter): malformed snippets in eslint/for-direction docs#6060

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/09-25-fix_linter_malformed_snippets_in_eslint_for-direction_docs
Sep 25, 2024
Merged

fix(linter): malformed snippets in eslint/for-direction docs#6060
graphite-app[bot] merged 1 commit intomainfrom
don/09-25-fix_linter_malformed_snippets_in_eslint_for-direction_docs

Conversation

@DonIsaac
Copy link
Contributor

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac added the C-bug Category - Bug label Sep 25, 2024 — with Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@DonIsaac DonIsaac added the C-docs Category - Documentation. Related to user-facing or internal documentation label Sep 25, 2024 — with Graphite App
@github-actions github-actions bot added A-linter Area - Linter and removed C-docs Category - Documentation. Related to user-facing or internal documentation labels Sep 25, 2024
@DonIsaac DonIsaac marked this pull request as ready for review September 25, 2024 21:43
@DonIsaac
Copy link
Contributor Author

Trivial docs fix, so I'm merging w/o review.

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Sep 25, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2024

Merge activity

  • Sep 25, 5:43 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 25, 5:47 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Sep 25, 5:52 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.

@DonIsaac DonIsaac force-pushed the don/09-25-fix_linter_malformed_snippets_in_eslint_for-direction_docs branch from 9ad7070 to 3da3845 Compare September 25, 2024 21:47
@graphite-app graphite-app bot merged commit 3da3845 into main Sep 25, 2024
@graphite-app graphite-app bot deleted the don/09-25-fix_linter_malformed_snippets_in_eslint_for-direction_docs branch September 25, 2024 21:52
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #6060 will not alter performance

Comparing don/09-25-fix_linter_malformed_snippets_in_eslint_for-direction_docs (3da3845) with main (a4fdf1b)

Summary

✅ 29 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Sep 27, 2024
Boshen added a commit that referenced this pull request Sep 27, 2024
## [0.9.9] - 2024-09-27

### Bug Fixes

- bd8f786 linter: Rule and generic filters do not re-configure existing
rules (#6087) (DonIsaac)
- c5cdb4c linter: Disable all rules in a plugin when that plugin gets
turned off (#6086) (DonIsaac)
- 6c855af linter: Only write fix results if source code has changed
(#6096) (DonIsaac)
- 8759528 linter: Category filters not re-configuring already-enabled
rules (#6085) (DonIsaac)
- c2616f7 linter: Fix panic in fixer for `oxc/only-used-in-recursion`
(#6070) (camc314)
- 3da3845 linter: Malformed snippets in `eslint/for-direction` docs
(#6060) (DonIsaac)
- c047d42 linter: `no-useless-escape`: do not crash on backslash
character (#6048) (camchenry)
- 6f76ebe linter: Ignore invalid or partial disable directives (#6045)
(camchenry)
- 09a24cd linter: Fix false positives for generics in
`no-unexpected-multiline` (#6039) (camchenry)
- d05fd20 linter: Newline in type parameters causing false positive in
`no-unexpected-multiline` (#6031) (DonIsaac)
- 01b9c4b npm/oxlint: Make bin/oxc_language_server an executable (#6066)
(Boshen)

### Performance

- f8464a3 linter: `no-magic-numbers` remove redudant checks in
`is_array_index` (#6033) (Alexander S.)
- c16ae60 linter: `jest/prefer-hooks-in-order`: rewrite rule to allocate
less and iterate fewer times (#6030) (camchenry)

### Documentation

- a4fdf1b linter: Improve docs for promise rules (#6051) (dalaoshu)
- 21cdb78 linter: Fix incorrect "bad" example in
`only-used-in-recursion` (#6029) (Boshen)

### Refactor

- 1f92d61 linter: `jest/prefer-hooks-in-order`: improve diagnostic
messages (#6036) (camchenry)

### Testing

- 55949eb linter: Add `OxlintRules::override_rules` tests (#6081)
(DonIsaac)
- 1a6923a linter: Add filter parsing test cases (#6080) (DonIsaac)
- 58d333a linter: Add more test cases for disable directives (#6047)
(camchenry)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant