feat(codegen): print vite / webpack special comments#6021
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 26, 2024
Merged
feat(codegen): print vite / webpack special comments#6021graphite-app[bot] merged 1 commit intomainfrom
vite / webpack special comments#6021graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #6021 will not alter performanceComparing Summary
|
Dunqing
changed the title
Dunqing
changed the title
Dunqing
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
c64a88d to
c54bd53
Compare
Dunqing
changed the base branch from
main
to
09-24-refactor_codegen_simplify_printing_annotation_comments
Dunqing
force-pushed
the
09-24-refactor_codegen_simplify_printing_annotation_comments
branch
from
3474b45 to
138ccc9
Compare
Dunqing
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
c54bd53 to
c7a7586
Compare
Dunqing
changed the base branch from
09-24-refactor_codegen_simplify_printing_annotation_comments
to
graphite-base/6021
Dunqing
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
c7a7586 to
bc55004
Compare
Dunqing
force-pushed
the
graphite-base/6021
branch
from
138ccc9 to
fe696f0
Compare
Dunqing
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
bc55004 to
e9cca9b
Compare
Dunqing
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
e9cca9b to
2ee73ba
Compare
Dunqing
changed the title
vite / webpack special comments
Dunqing
commented
Sep 26, 2024
Member
Author
|
A lot of EDIT: Fixed in #6065 |
Dunqing
commented
Sep 26, 2024
Dunqing
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
49f34f5 to
c96027a
Compare
github-actions
bot
added
A-minifier
Boshen
pushed a commit
that referenced
this pull request
Sep 26, 2024
Dunqing
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
c96027a to
3f8db9b
Compare
Boshen
requested changes
Sep 26, 2024
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
Can we add some integration tests for vite special comments, including tests that don't match these webpack / vite patterns?
You may add them to crates/oxc_codegen/tests/integration/unit.rs or merge them in pure_comments.rs
Member
Author
I added tests for vite special comments in crates/oxc_codegen/tests/integration/unit.rs and non-special comments tests which copy from esbuild in esbuild |
Boshen
approved these changes
Sep 26, 2024
Contributor
Merge activity
|
Related: #1046 (comment) Close: #6024
Boshen
force-pushed
the
09-24-refactor_codegen_print_inner_comments
branch
from
15f265a to
cca433f
Compare
graphite-app
bot
deleted the
09-24-refactor_codegen_print_inner_comments
branch
Boshen
added a commit
that referenced
this pull request
Sep 27, 2024
## [0.30.2] - 2024-09-27 ### Features - 60c52ba ast: Allow passing span to `void_0` method (#6065) (Dunqing) - cca433f codegen: Print `vite` / `webpack` special comments (#6021) (Dunqing) - 8d026e1 regular_expression: Implement `GetSpan` for RegExp AST nodes (#6056) (camchenry) - 7764793 regular_expression: Implement visitor pattern trait for regex AST (#6055) (camchenry) - f866781 semantic: Check for type annotations on left side of `for..in` and `for..of` iterators (#6043) (DonIsaac) - 8b2e9aa semantic: Check for JSDoc types in TS type annotations (#6042) (DonIsaac) - 28da771 transformer: Do not transform `**` with bigint literals (#6023) (Boshen) ### Bug Fixes - a88504c diagnostics: Check for terminal when displaying links (#6018) (Boshen) - 418ae25 isolated-declarations: Report uninferrable types in arrays (#6084) (michaelm) - e0a8959 minifier: Compute `void number` as `undefined` (#6028) (Boshen) - 0658576 paresr: Do not report missing initializer error in ambient context (#6020) (Boshen) - b1af73d semantic: Do not create a `global` symbol for `declare global {}` (#6040) (DonIsaac) - c8682e9 semantic,codegen,transformer: Handle definite `!` operator in variable declarator (#6019) (Boshen) ### Performance - 6b7d3ed isolated-declarations: Should clone transformed AST rather than original AST (#6078) (Dunqing) - 85aff19 transformer: Introduce `Stack` (#6093) (overlookmotel) - ad4ef31 transformer: Introduce `NonEmptyStack` (#6092) (overlookmotel) ### Documentation - 3099709 allocator: Document `oxc_allocator` crate (#6037) (DonIsaac) - d60ceb4 oxc: Add README.md and crate-level docs (#6035) (DonIsaac) - efabfc8 semantic: Improve doc comments on `Reference` methods (#6076) (overlookmotel) ### Refactor - 1fc80d1 ast: Move all ts ast related impl methods to `ast_impl` (#6015) (Dunqing) - fe696f0 codegen: Simplify printing annotation comments (#6027) (Dunqing) - e60ce50 transformer: Add `SparseStack::with_capacity` method (#6094) (overlookmotel) - 1399d2c transformer: Move `SparseStack` definition into folder (#6091) (overlookmotel) - 6bd29dd transformer: Add more debug assertions (#6090) (overlookmotel) - c90b9bf transformer: Rename `SparseStack` methods (#6089) (overlookmotel) - 2b380c8 transformer: Remove unsued `self.ctx` (#6022) (Boshen) ### Testing - 93575cd semantic: Add comprehensive regression test suite (#5976) (DonIsaac) - a4cec75 transformer: Enable tests (#6032) (overlookmotel) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1046 (comment)
Close: #6024