Skip to content

Comments

fix(linter): fix panic in sort-keys#6017

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-24-fix_linter_fix_panic_in_sort-keys
Sep 24, 2024
Merged

fix(linter): fix panic in sort-keys#6017
graphite-app[bot] merged 1 commit intomainfrom
09-24-fix_linter_fix_panic_in_sort-keys

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Sep 24, 2024

closes #5773

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Sep 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Sep 24, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 24, 2024

Merge activity

@Boshen Boshen force-pushed the 09-24-fix_linter_fix_panic_in_sort-keys branch from bd6c7d5 to e3c8a12 Compare September 24, 2024 06:51
@graphite-app graphite-app bot merged commit e3c8a12 into main Sep 24, 2024
@graphite-app graphite-app bot deleted the 09-24-fix_linter_fix_panic_in_sort-keys branch September 24, 2024 06:55
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 24, 2024

CodSpeed Performance Report

Merging #6017 will not alter performance

Comparing 09-24-fix_linter_fix_panic_in_sort-keys (e3c8a12) with main (1fc80d1)

Summary

✅ 29 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Sep 24, 2024
Boshen added a commit that referenced this pull request Sep 24, 2024
## [0.9.8] - 2024-09-24

### Bug Fixes

- e3c8a12 linter: Fix panic in sort-keys (#6017) (Boshen)
- 4771492 linter: Fix `import/no_cycle` with `ignoreTypes` (#5995)
(Boshen)

### Performance

- 5ae3f36 linter: `no-fallthrough`: Use string matching instead of Regex
for default comment pattern (#6008) (camchenry)
- 2b17003 linter, prettier, diagnostics: Use `FxHashMap` instead of
`std::collections::HashMap` (#5993) (camchenry)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic user-provided comparison function does not correctly implement a total order in oxc_linter::rules::eslint::sort_keys::alphanumeric_sort

1 participant