perf(linter): no-fallthrough: Use string matching instead of Regex for default comment pattern#6008
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 24, 2024
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @camchenry and the rest of your teammates on |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
camchenry
force-pushed
the
09-23-perf_linter_no-fallthrough_use_string_matching_instead_of_regex_for_default_comment_pattern
branch
from
abc0b33 to
eb09ff1
Compare
CodSpeed Performance ReportMerging #6008 will not alter performanceComparing Summary
|
DonIsaac
approved these changes
Sep 24, 2024
Contributor
Merge activity
|
…for default comment pattern (#6008) Profiling has shown this rule to be a consistent slow point, and in particular, the Regex construction is slow. <img width="1323" alt="Screenshot 2024-09-23 at 7 12 58 PM" src="https://github.com/user-attachments/assets/1d9b367d-eeda-4b19-b0a3-463e54ac4334"> This PR improves the situation in two ways: 1. A `Regex` is only constructed when there is a custom comment pattern (which is likely the minority of cases) 2. For the default comment pattern (when no custom pattern is passed), we now use a simple string matcher function, instead of a full-blown regex matcher. I believe this should be faster since it involves much less work, though can still allocate a `String`.
DonIsaac
force-pushed
the
09-23-perf_linter_no-fallthrough_use_string_matching_instead_of_regex_for_default_comment_pattern
branch
from
eb09ff1 to
5ae3f36
Compare
graphite-app
bot
deleted the
09-23-perf_linter_no-fallthrough_use_string_matching_instead_of_regex_for_default_comment_pattern
branch
Boshen
added a commit
that referenced
this pull request
Sep 24, 2024
## [0.9.8] - 2024-09-24 ### Bug Fixes - e3c8a12 linter: Fix panic in sort-keys (#6017) (Boshen) - 4771492 linter: Fix `import/no_cycle` with `ignoreTypes` (#5995) (Boshen) ### Performance - 5ae3f36 linter: `no-fallthrough`: Use string matching instead of Regex for default comment pattern (#6008) (camchenry) - 2b17003 linter, prettier, diagnostics: Use `FxHashMap` instead of `std::collections::HashMap` (#5993) (camchenry) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling has shown this rule to be a consistent slow point, and in particular, the Regex construction is slow.
This PR improves the situation in two ways:
Regexis only constructed when there is a custom comment pattern (which is likely the minority of cases)String.