Skip to content

Comments

fix(codegen): print jsdoc comments for TSEnumMembers#6007

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/09-23-fix_codegen_print_jsdoc_comments_for_tsenummember_s
Sep 24, 2024
Merged

fix(codegen): print jsdoc comments for TSEnumMembers#6007
graphite-app[bot] merged 1 commit intomainfrom
c/09-23-fix_codegen_print_jsdoc_comments_for_tsenummember_s

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Sep 23, 2024

closes #6006

Boshen/Dunqing please feel free to take over this PR. it's a bit outside what i normally work on. 🙂

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-codegen Area - Code Generation label Sep 23, 2024
Copy link
Contributor Author

camc314 commented Sep 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on Graphite Graphite

@camc314 camc314 marked this pull request as ready for review September 23, 2024 20:06
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #6007 will not alter performance

Comparing c/09-23-fix_codegen_print_jsdoc_comments_for_tsenummember_s (4a99372) with main (5ae3f36)

Summary

✅ 29 untouched benchmarks

@DonIsaac
Copy link
Contributor

Looks like a straightforward change. LGTM.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 24, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 24, 2024

Merge activity

  • Sep 23, 9:12 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 9:12 PM EDT: Dunqing added this pull request to the Graphite merge queue.
  • Sep 23, 9:19 PM EDT: Dunqing merged this pull request with the Graphite merge queue.

closes #6006

Boshen/Dunqing please feel free to take over this PR. it's a bit outside what i normally work on. 🙂
@Dunqing Dunqing force-pushed the c/09-23-fix_codegen_print_jsdoc_comments_for_tsenummember_s branch from bea56c7 to 4a99372 Compare September 24, 2024 01:13
@graphite-app graphite-app bot merged commit 4a99372 into main Sep 24, 2024
@graphite-app graphite-app bot deleted the c/09-23-fix_codegen_print_jsdoc_comments_for_tsenummember_s branch September 24, 2024 01:19
Boshen added a commit that referenced this pull request Sep 24, 2024
## [0.30.1] - 2024-09-24

### Features

- 5c323a2 minifier: Loop compressor passes (#6013) (Boshen)

### Bug Fixes

- 9ca202a codegen: Preserve newlines between comments (#6014) (Boshen)
- 4a99372 codegen: Print jsdoc comments for `TSEnumMember`s (#6007)
(camc314)
- 97a2c41 isolated-declarations: False positive for class private getter
with non-inferrable return type (#5987) (michaelm)

### Performance

- 2b17003 linter, prettier, diagnostics: Use `FxHashMap` instead of
`std::collections::HashMap` (#5993) (camchenry)
- 7b90d79 transformer: `SparseStack` always keep minimum 1 entry (#5962)
(overlookmotel)
- 28fe80a transformer: Logical assignment operator transform use
`SparseStack` (#5960) (overlookmotel)
- 9f7d4b7 transformer: Exponentiation operator transform use
`SparseStack` (#5959) (overlookmotel)
- 5dc0154 transformer: Nullish coalescing operator transform use
`SparseStack` (#5942) (overlookmotel)
- 618e89e transformer: Arrow function transform: reduce stack memory
usage (#5940) (overlookmotel)

### Documentation

- 5a0d17c ast: Document more AST nodes (#6000) (DonIsaac)
- 18371dd oxc: Include feature-guarded modules in docs.rs (#6012)
(DonIsaac)
- 1abfe8f semantic: Document `SymbolTable` (#5998) (DonIsaac)
- f5eee72 semantic: Correct docs for `Reference` (#5992) (overlookmotel)
- 860f108 transformer: Add to arrow functions transform docs (#5989)
(overlookmotel)

### Refactor

- 0a2f687 minifier: Move dce conditional expression to `RemoveDeadCode`
(#5971) (Boshen)
- f02bf51 transformer: Arrow function transform: remove unnecessary
assertion (#6002) (overlookmotel)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing JSDoc for enum members

3 participants