Skip to content

Comments

perf(ast-tools): use FxHashMap over std::collections::HashMap#5997

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_
Sep 23, 2024
Merged

perf(ast-tools): use FxHashMap over std::collections::HashMap#5997
graphite-app[bot] merged 1 commit intomainfrom
09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_

Conversation

@camchenry
Copy link
Member

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #5997 will not alter performance

Comparing 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ (02d5637) with main (f02bf51)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen changed the base branch from 09-23-perf_linter_prettier_diagnostics_use_fxhashmap_instead_of_std_collections_hashmap_ to graphite-base/5997 September 23, 2024 16:29
@Boshen Boshen force-pushed the 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ branch from 058fee9 to 685bf15 Compare September 23, 2024 16:35
@Boshen Boshen changed the base branch from graphite-base/5997 to main September 23, 2024 16:38
@Boshen Boshen force-pushed the 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ branch from 685bf15 to 7a90d6e Compare September 23, 2024 16:38
@camchenry camchenry force-pushed the 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ branch 3 times, most recently from 17ee041 to fe42425 Compare September 23, 2024 17:23
@camchenry camchenry marked this pull request as ready for review September 23, 2024 17:23
@camchenry camchenry changed the title perf(tasks): use FxHashMap over std::collections::HashMap perf(ast-tools): use FxHashMap over std::collections::HashMap Sep 23, 2024
@camchenry camchenry requested a review from Boshen September 23, 2024 17:36
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 23, 2024

Merge activity

  • Sep 23, 2:28 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 2:28 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 23, 2:34 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ branch from fe42425 to 02d5637 Compare September 23, 2024 18:29
@graphite-app graphite-app bot merged commit 02d5637 into main Sep 23, 2024
@graphite-app graphite-app bot deleted the 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ branch September 23, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants