Skip to content

Comments

docs(semantic): document SymbolTable#5978

Closed
DonIsaac wants to merge 1 commit intodon/09-22-test_semantic_add_comprehensive_regression_test_suitefrom
don/09-22-docs_semantic_document_symboltable_
Closed

docs(semantic): document SymbolTable#5978
DonIsaac wants to merge 1 commit intodon/09-22-test_semantic_add_comprehensive_regression_test_suitefrom
don/09-22-docs_semantic_document_symboltable_

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Sep 22, 2024

Part of #5870

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST labels Sep 22, 2024
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@DonIsaac DonIsaac added the C-docs Category - Documentation. Related to user-facing or internal documentation label Sep 22, 2024 — with Graphite App
@DonIsaac DonIsaac marked this pull request as ready for review September 22, 2024 21:45
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2024

CodSpeed Performance Report

Merging #5978 will not alter performance

Comparing don/09-22-docs_semantic_document_symboltable_ (c8f1f61) with don/09-22-test_semantic_add_comprehensive_regression_test_suite (15b6b3b)

Summary

✅ 29 untouched benchmarks

/// ```ts
/// // Function overloads will not have a body
/// function add(a: number, b: number): number; // <-- No body
/// function add(a: string, b: string): string; // <-- No bod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no body ?

@overlookmotel
Copy link
Member

Could you please move this into its own stack, rather than stacked on top of #5976 so can get it merged ASAP? #5976 may take a while to review.

Apart from the typo which @daflyinbed spotted, this looks good to me.

Just a note: I would have preferred if this PR had been split in 2 for (1) AST type docs and (2) SymbolTable docs. They wouldn't even need to be stacked on top of each other as they're independent changes. No need to split it up now, just saying for next time...

@DonIsaac DonIsaac force-pushed the don/09-22-test_semantic_add_comprehensive_regression_test_suite branch from 2623aa8 to 1d70aab Compare September 23, 2024 15:45
@DonIsaac DonIsaac force-pushed the don/09-22-docs_semantic_document_symboltable_ branch from 3c6370c to 0fa67b3 Compare September 23, 2024 15:46
@DonIsaac DonIsaac force-pushed the don/09-22-test_semantic_add_comprehensive_regression_test_suite branch from 1d70aab to 87f4f94 Compare September 23, 2024 15:54
@DonIsaac DonIsaac force-pushed the don/09-22-docs_semantic_document_symboltable_ branch from 0fa67b3 to 7ca3344 Compare September 23, 2024 15:54
@DonIsaac DonIsaac force-pushed the don/09-22-test_semantic_add_comprehensive_regression_test_suite branch from 87f4f94 to f271380 Compare September 23, 2024 16:31
@DonIsaac DonIsaac force-pushed the don/09-22-docs_semantic_document_symboltable_ branch from 7ca3344 to cd85540 Compare September 23, 2024 16:31
@DonIsaac DonIsaac force-pushed the don/09-22-test_semantic_add_comprehensive_regression_test_suite branch from f271380 to 15b6b3b Compare September 23, 2024 16:31
@DonIsaac DonIsaac force-pushed the don/09-22-docs_semantic_document_symboltable_ branch from cd85540 to c8f1f61 Compare September 23, 2024 16:31
@DonIsaac
Copy link
Contributor Author

Re-created in #5998

@DonIsaac DonIsaac closed this Sep 23, 2024
DonIsaac added a commit that referenced this pull request Sep 23, 2024
@Boshen Boshen deleted the don/09-22-docs_semantic_document_symboltable_ branch February 17, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-semantic Area - Semantic C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants