Skip to content

Comments

fix(linter): include actual span size in no-regex-spaces diagnostic#5957

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic
Sep 22, 2024
Merged

fix(linter): include actual span size in no-regex-spaces diagnostic#5957
graphite-app[bot] merged 1 commit intomainfrom
09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic

Conversation

@camchenry
Copy link
Member

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

camchenry commented Sep 21, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 21, 2024

CodSpeed Performance Report

Merging #5957 will not alter performance

Comparing 09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic (eed9ac7) with main (a9a8e2a)

Summary

✅ 29 untouched benchmarks

@camchenry camchenry marked this pull request as ready for review September 21, 2024 22:22
@camchenry camchenry force-pushed the linter/refactor-no-regex-spaces branch from 4b53226 to ed7fabd Compare September 22, 2024 02:11
@camchenry camchenry force-pushed the 09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic branch from d10664e to 1b54b1f Compare September 22, 2024 03:16
@camchenry camchenry force-pushed the linter/refactor-no-regex-spaces branch from ed7fabd to 1a1e436 Compare September 22, 2024 03:17
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 22, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 22, 2024

Merge activity

  • Sep 22, 12:33 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 22, 12:45 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 22, 12:50 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen changed the base branch from linter/refactor-no-regex-spaces to graphite-base/5957 September 22, 2024 04:33
@Boshen Boshen force-pushed the 09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic branch from 1b54b1f to 5645d3e Compare September 22, 2024 04:38
@Boshen Boshen changed the base branch from graphite-base/5957 to main September 22, 2024 04:39
@Boshen Boshen force-pushed the 09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic branch from 5645d3e to fbe404f Compare September 22, 2024 04:39
@Boshen Boshen force-pushed the 09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic branch from fbe404f to eed9ac7 Compare September 22, 2024 04:45
@graphite-app graphite-app bot merged commit eed9ac7 into main Sep 22, 2024
@graphite-app graphite-app bot deleted the 09-21-fix_linter_include_actual_span_size_in_no-regex-spaces_diagnostic branch September 22, 2024 04:50
@oxc-bot oxc-bot mentioned this pull request Sep 23, 2024
Boshen added a commit that referenced this pull request Sep 23, 2024
## [0.9.7] - 2024-09-23

### Features

- d24985e linter: Add `oxc-security/api-keys` (#5906) (DonIsaac)
- f9b44c5 linter: Add unicode sets support to `no-useless-escape` rule
(#5974) (camchenry)
- 0f19848 linter: Implement `no-unexpected-multiline` rule (#5911)
(camchenry)
- 16fe383 linter: Implement `no-extend-native` rule (#5867) (Cam
McHenry)

### Bug Fixes

- eed9ac7 linter: Include actual span size in `no-regex-spaces`
diagnostic (#5957) (camchenry)
- 40c89c2 linter: Move `promise/avoid-new` to style category (#5961)
(DonIsaac)

### Performance

- 608d637 linter: Use `aho-corasick` instead of `regex` for string
matching in `jsx-a11y/img-redundant-alt` (#5892) (camchenry)
- 3148d4b linter: Check file path after checking node kind for
`nextjs/no-head-element` (#5868) (Cam McHenry)

### Refactor

- 0a5a4a9 linter: Use parsed patterns for `unicorn/no-hex-escape`
(#5985) (camchenry)
- 2cf2edd linter: Use parsed patterns in `no-empty-character-class` rule
(#5980) (camchenry)
- a9a8e2a linter: Use regex parser in `eslint/no-regex-spaces` (#5952)
(camchenry)
- 05f592b linter: Use parsed patterns in
`unicorn/prefer-string-starts-ends-with` (#5949) (camchenry)
- 3273b64 linter: Use parsed patterns for
`unicorn/prefer-string-replace-all` rule (#5943) (camchenry)
- ba7b01f linter: Add `LinterBuilder` (#5714) (DonIsaac)
- db4f16a semantic: Call `with_trivias` before `build_with_jsdoc`
(#5875) (Boshen)
- 3d13c6d semantic: Impl `IntoIterator` for `&AstNodes` (#5873)
(DonIsaac)

### Testing

- b681c9a linter: Import test cases for `no-empty-character-class`
(#5981) (camchenry)
- 767602b linter: Add regression test for #5227 (#5975) (camchenry)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants