Skip to content

Comments

refactor(macros): clean up declare_oxc_secret#5937

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/09-20-refactor_macros_clean_up_declare_oxc_secret
Oct 16, 2024
Merged

refactor(macros): clean up declare_oxc_secret#5937
graphite-app[bot] merged 1 commit intomainfrom
don/09-20-refactor_macros_clean_up_declare_oxc_secret

Conversation

@DonIsaac
Copy link
Contributor

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 20, 2024 — with Graphite App
@DonIsaac DonIsaac marked this pull request as ready for review September 20, 2024 19:24
Copy link
Contributor Author

DonIsaac commented Sep 20, 2024

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #5937 will not alter performance

Comparing don/09-20-refactor_macros_clean_up_declare_oxc_secret (87f3b8d) with main (b3d0cce)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/09-19-feat_linter_add_oxc-security_api-keys_ branch from 5201623 to fc95223 Compare September 20, 2024 20:36
@DonIsaac DonIsaac force-pushed the don/09-20-refactor_macros_clean_up_declare_oxc_secret branch from bb083e8 to 5be8cd9 Compare September 20, 2024 20:36
@DonIsaac DonIsaac force-pushed the don/09-19-feat_linter_add_oxc-security_api-keys_ branch from fc95223 to 20068ec Compare September 21, 2024 21:13
@DonIsaac DonIsaac changed the base branch from don/09-19-feat_linter_add_oxc-security_api-keys_ to graphite-base/5937 September 22, 2024 22:39
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Sep 22, 2024
@DonIsaac DonIsaac force-pushed the don/09-20-refactor_macros_clean_up_declare_oxc_secret branch from 5be8cd9 to 3015a91 Compare September 25, 2024 17:15
@DonIsaac DonIsaac changed the base branch from graphite-base/5937 to main September 25, 2024 17:15
@overlookmotel
Copy link
Member

I have no idea what declare_oxc_secret is, so can't really review this. Feel free to merge if you're happy with it.

@overlookmotel overlookmotel removed their request for review September 25, 2024 23:17
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 16, 2024
Copy link
Contributor Author

DonIsaac commented Oct 16, 2024

Merge activity

  • Oct 16, 4:08 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 16, 4:09 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 16, 4:15 PM EDT: A user merged this pull request with the Graphite merge queue.

@DonIsaac DonIsaac force-pushed the don/09-20-refactor_macros_clean_up_declare_oxc_secret branch from 652e8b8 to 87f3b8d Compare October 16, 2024 20:10
@graphite-app graphite-app bot merged commit 87f3b8d into main Oct 16, 2024
@graphite-app graphite-app bot deleted the don/09-20-refactor_macros_clean_up_declare_oxc_secret branch October 16, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants