Skip to content

Comments

test(transformer): add test for arrow function transform#5932

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-20-test_transformer_add_test_for_arrow_function_transform
Sep 21, 2024
Merged

test(transformer): add test for arrow function transform#5932
graphite-app[bot] merged 1 commit intomainfrom
09-20-test_transformer_add_test_for_arrow_function_transform

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 20, 2024

Add test for this in nested block inside arrow function.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel force-pushed the 09-20-test_transformer_add_test_for_arrow_function_transform branch 2 times, most recently from c9cbd26 to 91dea61 Compare September 20, 2024 14:42
@overlookmotel overlookmotel marked this pull request as ready for review September 20, 2024 14:43
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 20, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #5932 will degrade performances by 4.11%

Comparing 09-20-test_transformer_add_test_for_arrow_function_transform (ad7ebf3) with main (f07ff14)

Summary

❌ 3 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 09-20-test_transformer_add_test_for_arrow_function_transform Change
transformer[antd.js] 51.6 ms 53.4 ms -3.37%
transformer[checker.ts] 20.9 ms 21.8 ms -4.11%
transformer[pdf.mjs] 7.6 ms 7.9 ms -3.38%

@overlookmotel overlookmotel force-pushed the 09-20-test_transformer_add_test_for_arrow_function_transform branch from 91dea61 to 483f192 Compare September 20, 2024 15:10
@overlookmotel
Copy link
Member Author

Why is adding a test regressing benchmarks by 4%??! Clearly erroneous...

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 21, 2024

Merge activity

  • Sep 20, 8:53 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 20, 8:53 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 20, 8:59 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

Add test for `this` in nested block inside arrow function.
@overlookmotel overlookmotel force-pushed the 09-20-test_transformer_add_test_for_arrow_function_transform branch from 9f77ef2 to 1574334 Compare September 21, 2024 00:53
@graphite-app graphite-app bot merged commit 1574334 into main Sep 21, 2024
@graphite-app graphite-app bot deleted the 09-20-test_transformer_add_test_for_arrow_function_transform branch September 21, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants