refactor(ast_tools): shorten code#5915
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 20, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #5915 will not alter performanceComparing Summary
|
camchenry
approved these changes
Sep 20, 2024
Member
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
Nice, this seems like a good follow up to me
Member
Author
|
Thanks for reviewing @camchenry! |
Contributor
Merge activity
|
#5904 reduced the generated code for `Visit` trait. Shorten the codegen a little after that change.
overlookmotel
force-pushed
the
09-20-refactor_ast_tools_shorten_code
branch
from
f3b85dd to
b80a9ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5904 reduced the generated code for
Visittrait. Shorten the codegen a little after that change.