perf(transformer): reuse same UID for _this in arrow function transform#5840
Closed
overlookmotel wants to merge 1 commit into09-17-feat_traverse_generate_uid_name_methodfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Sep 17, 2024
This was referenced Sep 17, 2024
Member
Author
CodSpeed Performance ReportMerging #5840 will not alter performanceComparing Summary
|
Member
Author
|
Interesting. |
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Re-use same
_thisUID for every scope, instead of creating a new one each time -_this,_this2etc. It's not necessary for each var to have a different name, as only onethiscan be in scope anywhere.Conformance fails because some of Babel's test cases rely on every
_thisvar to be named differently, so we can't merge this, but submitting PR just to see the effect on benchmarks.