docs(parser): share oxc_parser module docs with oxc::parser#5832
docs(parser): share oxc_parser module docs with oxc::parser#5832
oxc_parser module docs with oxc::parser#5832Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
8091873 to
0f382ba
Compare
ba67ef6 to
7148cdf
Compare
CodSpeed Performance ReportMerging #5832 will not alter performanceComparing Summary
|
0f382ba to
3120c6c
Compare
7148cdf to
a5e0c7a
Compare
a5e0c7a to
95b63f9
Compare
Did you mean examples in loaded files are not run? |
I did not. Given this README: Here's a description for some stuff
## Example
'''rust
#![doc = include_str!("../examples/foo.rs")]
'''
When this gets loaded in as documentation in #![doc = include_str!("../README.md")]then the macro invocation in |
|
Ah. Now I understand. Thanks for explaining. |
95b63f9 to
d1bda46
Compare
What This PR Does Moves `oxc_parser` module documentation to a README.md file so that the `oxc` crate can benefit from it as well. The downside of this PR is that it breaks example inclusion with `#![doc include_str(..)]`, since macros in loaded files are not run. I'm not 100% sure that the tradeoffs are worth it, but this is worth discussing.
d1bda46 to
174c0dc
Compare
|
This seems confusing, maybe just a docs.rs link to the actual crate should suffice? |

What This PR Does
Moves
oxc_parsermodule documentation to a README.md file so that theoxccrate can benefit from it as well.The downside of this PR is that it breaks example inclusion with
#![doc include_str(..)], since macros in loaded files are not run. I'mnot 100% sure that the tradeoffs are worth it, but this is worth
discussing.