fix(linter): remove all* remaining "Disallow <foo>" messages#5812
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 17, 2024
Merged
Conversation
This was referenced Sep 16, 2024
Contributor
Author
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
DonIsaac
force-pushed
the
don/09-16-fix_linter_remove_all_remaining_disallow_foo_messages
branch
from
7be3a0b to
b7d13ad
Compare
CodSpeed Performance ReportMerging #5812 will not alter performanceComparing Summary
|
DonIsaac
force-pushed
the
don/09-16-feat_linter_make_typescript/no-duplicate-enum-values_a_correctness_rule
branch
from
4a2709f to
65b72e9
Compare
DonIsaac
force-pushed
the
don/09-16-fix_linter_remove_all_remaining_disallow_foo_messages
branch
from
b7d13ad to
4abd544
Compare
Contributor
Merge activity
|
Cleans diagnostic messages and help texts for (almost) all remaining rules. There were two rules I couldn' find good replacements for. I also made some logical improvements to a few rules, and added `pending` fixers to others.
Boshen
force-pushed
the
don/09-16-feat_linter_make_typescript/no-duplicate-enum-values_a_correctness_rule
branch
from
65b72e9 to
3bf7b24
Compare
Boshen
force-pushed
the
don/09-16-fix_linter_remove_all_remaining_disallow_foo_messages
branch
from
4abd544 to
f942485
Compare
Base automatically changed from
don/09-16-feat_linter_make_typescript/no-duplicate-enum-values_a_correctness_rule
to
main
September 17, 2024 05:58
graphite-app
bot
deleted the
don/09-16-fix_linter_remove_all_remaining_disallow_foo_messages
branch
Boshen
added a commit
that referenced
this pull request
Sep 18, 2024
## [0.9.6] - 2024-09-18 ### Features - 3bf7b24 linter: Make `typescript/no-duplicate-enum-values` a `correctness` rule (#5810) (DonIsaac) - 7799c06 linter/react: Implement `no-danger-with-children` rule (#5420) (Cam McHenry) ### Bug Fixes - f942485 linter: Remove all* remaining "Disallow <foo>" messages (#5812) (DonIsaac) - b5ad518 linter: Improve diagnostic messages for various lint rules (#5808) (DonIsaac) - 858f7af linter: Plugin prefix name for eslint-plugin-node (#5807) (DonIsaac) - 737ba1d linter: Fix some cases on ```AssignmentExpression``` for ```unicorn/consistent-function-scoping``` (#5675) (Arian94) - 148c7a8 linter: Replace bitwise AND (&) with logical AND (&&) in explici… (#5780) (kaykdm) - b4ed564 linter/no-unused-vars: Writes to members triggering false positive (#5744) (Dunqing) - e9c084a linter/no-unused-vars: False positive when a variable used as a computed member property (#5722) (Dunqing) ### Performance - 3725d5d linter: Make all rules share a diagnostics vec (#5806) (DonIsaac) - e978567 linter: Shrink size of `DisableDirectives` (#5798) (DonIsaac) - 1bfa515 linter: Remove redundant clone of diagnostics in context (#5797) (DonIsaac) - e413cad linter: Move shared context info to `ContextHost` (#5795) (DonIsaac) ### Refactor - 6dd6f7c ast: Change `Comment` struct (#5783) (Boshen) - 7caae5b codegen: Add `GetSpan` requirement to `Gen` trait (#5772) (Boshen) - 026ee6a linter: Decouple module resolution from import plugin (#5829) (dalaoshu) - 50834bc linter: Move `override_rule` to `OxlintRules` (#5708) (DonIsaac) - a438743 linter: Move `OxlintConfig` to `Oxlintrc` (#5707) (DonIsaac) - f61e8b5 linter: Impl serde and schemars traits for `LintPlugins` (#5706) (DonIsaac) - 20a7861 linter: Shorten `Option` syntax (#5735) (overlookmotel) - d8b612c oxc_linter: Prefer pass Enum instead of str `no_plus_plus` (#5730) (IWANABETHATGUY) - cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans diagnostic messages and help texts for (almost) all remaining rules.
There were two rules I couldn' find good replacements for.
I also made some logical improvements to a few rules, and added
pendingfixersto others.